From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.10923.1675169731260877629 for ; Tue, 31 Jan 2023 04:55:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ixp9l1IZ; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B5F14B81BC5 for ; Tue, 31 Jan 2023 12:55:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71288C433D2 for ; Tue, 31 Jan 2023 12:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675169727; bh=ey9/T6nQF2VYa63XMAEhwf3el4F/uz8F444KZjpnyW4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ixp9l1IZjPEUDhYbr64Qlf2rZiTM6pdPZVZMYMDQe0RTS8an6FRcB7i/eLpT7t5Vg Vg/KBb11k6R58RrxfyrcUiOOt58MrxbOoxDLNdaHFzccefKo/11mrx2fnzHenjd+LV PvRYE10c50yTAFLDukwJlO7eJE98mV3G5oKMEWJrT263jQjzabTVpUTeq5j5F4E3Az 1nUupWtHhwlkZP8nf2aCUUEWDqO2GyXdFRm3vptPuQCLjNCZm8pk6P/i+HfA2n3IRX Sy3+UH3y7GlXhd55IZNXharzxHNKNqGR5oNCjiD7T6dLBQnyhmLElpyP2MjatTq18Q hagCYT4BrqFKg== Received: by mail-lf1-f54.google.com with SMTP id b3so24080136lfv.2 for ; Tue, 31 Jan 2023 04:55:27 -0800 (PST) X-Gm-Message-State: AFqh2ko/Voy5ZFLZpPTgsay7Zx3aZjVM6f0LlgnAQJZp8ZKwRTYzYUzy rXeCP/TSMaJEJKzVjQHOSFq0IYVXZcWtge0nTE4= X-Google-Smtp-Source: AMrXdXuYBzngUV/A4Eidz9jEFQ1P4L7Esa1mlKvEf6D9y8ZKBEkNrmSSiATs3RiqmfqdEry2Xvj3OB1evXYALwI6iew= X-Received: by 2002:ac2:44af:0:b0:4b6:e197:3aeb with SMTP id c15-20020ac244af000000b004b6e1973aebmr6953184lfm.233.1675169725488; Tue, 31 Jan 2023 04:55:25 -0800 (PST) MIME-Version: 1.0 References: <20230131054518.1576-1-aryeh.chen@intel.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 31 Jan 2023 13:55:14 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 To: "Chen, Aryeh" Cc: "devel@edk2.groups.io" , "Chiu, Chasel" , "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Content-Type: text/plain; charset="UTF-8" On Tue, 31 Jan 2023 at 08:47, Chen, Aryeh wrote: > > Hi Biesheuvel, > > The platform which before ADL, like TGL uses \_SB.PCI0, but ADL and later uses \_SB.PC00. > Minplatform should support all platform and Pcd PcdMinPciBridgePC00 can set on OpenBoard.dsc for PCI0 or PC00. > Thanks for the explanation. I think this is a rather ugly hack, but I suppose it is really needed. > > -----Original Message----- > From: Ard Biesheuvel > Sent: Tuesday, January 31, 2023 3:32 PM > To: devel@edk2.groups.io; Chen, Aryeh > Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric > Subject: Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 > > On Tue, 31 Jan 2023 at 06:46, Chen, Aryeh wrote: > > > > From: Aryeh Chen > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329 > > > > To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 on > > MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to > > \_SB.PC00 since Client ADL platform. > > > > Signed-off-by: Aryeh Chen > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Isaac Oram > > Cc: Liming Gao > > Cc: Eric Dong > > Why is this needed? > > > --- > > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4 ++++ > > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 + > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++ > > 3 files changed, 8 insertions(+) > > > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > index 4efb8709ac..b7361b6d44 100644 > > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > @@ -23,7 +23,11 @@ DefinitionBlock ( > > //--------------------------------------------------------------------------- > > // Begin PCI tree object scope > > > > //-------------------------------------------------------------------- > > ------- > > +#if FixedPcdGetBool (PcdMinPciBridgePC00) == 1 > > + Device(PC00) { // PCI Bridge "Host Bridge" > > +#else > > Device(PCI0) { // PCI Bridge "Host Bridge" > > +#endif > > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy > > Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID > > Name(_SEG, 0) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > > index 3437bc489c..b3b45039cc 100644 > > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > > @@ -40,6 +40,7 @@ > > [Pcd] > > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit > > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 > > > > [Depex] > > gEfiAcpiTableProtocolGuid AND > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > index e6f714b181..68a76db4de 100644 > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > @@ -139,6 +139,9 @@ > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UINT8|0x00010056 > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 > > > > + # The PCD controls MinDsdt PciBridge > > + > > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x00 > > + 010057 > > + > > # > > # FADT Duty Offset - The zero-based index of where the processor's duty cycle > > # setting is within the processor's P_CNT register. > > -- > > 2.26.2.windows.1 > > > > > > > > ------------ > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#99338): > > https://edk2.groups.io/g/devel/message/99338 > > Mute This Topic: https://groups.io/mt/96647478/1131722 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > > ------------ > > > >