From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 54513D8086D for ; Fri, 15 Mar 2024 09:51:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5VW/hZaCLoQna7EvSnN1o1m0/Ng+fNmbpo+M4yfay08=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710496287; v=1; b=UUHdkvpjQJKTHVLq3otpa/hBBRIg1DG+r3AVAxgBv6nEZ8BEK32iiqLo8fSuIHfeVdW2PVeU wIBl/Zk1P7u0AHAm78aSYEuXdr4PtQWhVNJclNNTwLPnkKrHrvJM6Z3gEjG/n2hAFjkXW3BlpPG fCvfNb2ME2V7Tc13ZeerQ3UkAaWNF0t1tb8tfP6xfzHaXMfNiMl4YEAMsp/iFf7zOrL9H62g0Mn sG9EIQjSEqc/41AC85IOw1Rqe66cmUH8TsVTAhpkBNH6yHMMQtkqMdmUGEdYCNNznYRGH+Jx8V6 r1fWJkfaWn0luMIPFUiXifrgwvYKPlDRXwjAW1lfOtVeg== X-Received: by 127.0.0.2 with SMTP id fYwNYY7687511x6C3vWmMf7G; Fri, 15 Mar 2024 02:51:27 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.17724.1710496286165631844 for ; Fri, 15 Mar 2024 02:51:26 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C47EFCE1F89 for ; Fri, 15 Mar 2024 09:51:22 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B8A8C433C7 for ; Fri, 15 Mar 2024 09:51:22 +0000 (UTC) X-Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5131a9b3d5bso2298359e87.0 for ; Fri, 15 Mar 2024 02:51:21 -0700 (PDT) X-Gm-Message-State: bFqddYR1DFoE6ntNvymb0WQfx7686176AA= X-Google-Smtp-Source: AGHT+IEL8gUcu1GwuqBHgtm/3tJsKeiqtRxQ6EEymUnVz0G3zIw7VIQ441JZuKQjCWcmhQkreWWGgZr/KRW7lwxFlv4= X-Received: by 2002:a19:2d15:0:b0:513:c8a6:5628 with SMTP id k21-20020a192d15000000b00513c8a65628mr3017189lfj.10.1710496280410; Fri, 15 Mar 2024 02:51:20 -0700 (PDT) MIME-Version: 1.0 References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093902.1254321-1-lichao@loongson.cn> <2c9c655d-6c17-4373-8dca-05196a86ca24@loongson.cn> In-Reply-To: <2c9c655d-6c17-4373-8dca-05196a86ca24@loongson.cn> From: "Ard Biesheuvel" Date: Fri, 15 Mar 2024 10:51:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library To: Chao Li Cc: devel@edk2.groups.io, kraxel@redhat.com, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 15 Mar 2024 02:51:26 -0700 Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UUHdkvpj; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Fri, 15 Mar 2024 at 10:49, Chao Li wrote: > > Hi Gerd, > > > Thanks, > Chao > On 2024/3/15 17:33, Gerd Hoffmann wrote: > > On Mon, Mar 11, 2024 at 05:39:02PM +0800, Chao Li wrote: > > Add a serial port hook library in LoongArchVirt named > Fdt16550SerialProtHookLib, this library is referenced from ArmVirtPkg. > > LoongArch QEMU virtual machine uses register of LOONGARCH_CSR_KS1 to > transfer serial port base addres from the PEI phase to the DXE phase. > > Why use LOONGARCH_CSR_KS1? Can't you simply set PcdSerialRegisterBase? > > The LoongArch QEMU PEI stage runs on flash and does not allow set PCD operations(memory have not enabled), so the address can only be transferred through a SAVE register. > Then maybe use a HOB instead? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116797): https://edk2.groups.io/g/devel/message/116797 Mute This Topic: https://groups.io/mt/104859892/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-