From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, quic_rcran@quicinc.com,
Sami Mujawar <sami.mujawar@arm.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Jian J Wang <jian.j.wang@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Tiger Liu <TigerLiu@zhaoxin.com>, Kun Qin <kuqin12@gmail.com>,
Rebecca Cran <rebecca@quicinc.com>
Subject: Re: [edk2-devel] [PATCH v5 0/2] ArmPkg: Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64
Date: Fri, 27 Jan 2023 15:02:59 +0100 [thread overview]
Message-ID: <CAMj1kXG-hKCgedBsXTsaUfO69Q5v+a2vH=ebSDEktnGqfCx-2A@mail.gmail.com> (raw)
In-Reply-To: <7bb8ae7b-1c77-7eff-4c43-33b0f757d096@bsdio.com>
On Fri, 27 Jan 2023 at 05:10, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> Could I get some more reviews on this please?
>
>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Thanks a lot for your persistence.
Queued up here
https://github.com/tianocore/edk2/pull/3956
>
> On 1/16/23 21:57, Rebecca Cran wrote:
> > Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64.
> >
> > Note that several tests from UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol
> > will fail because there's currently no mechanism implemented to reset
> > APs that are stuck running the user's code (e.g. tests that run an
> > infinite loop).
> > On x86 an IPI is sent to take back control: something similar should be
> > implemented on Arm.
> >
> > Changes from v4:
> >
> > o Changes based on review feedback from Kun Qin.
> > o Dropped the MpServicesTest patch, since
> > UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol implements similar
> > functionality.
> >
> > Changes from v2:
> >
> > Added a CPU exception handler for the APs so that if the user's code
> > causes an exception (e.g. because the application terminates) the AP
> > state is set to CpuStateFinished and the core powered off.
> >
> > Rebecca Cran (2):
> > ArmPkg: Add GET_MPIDR_AFFINITY_BITS and MPIDR_MT_BIT to ArmLib.h
> > ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls
> >
> > ArmPkg/ArmPkg.dsc | 1 +
> > ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf | 56 +
> > ArmPkg/Drivers/ArmPsciMpServicesDxe/MpServicesInternal.h | 345 ++++
> > ArmPkg/Include/Library/ArmLib.h | 16 +-
> > ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c | 1859 ++++++++++++++++++++
> > ArmPkg/Drivers/ArmPsciMpServicesDxe/MpFuncs.S | 74 +
> > 6 files changed, 2344 insertions(+), 7 deletions(-)
> > create mode 100644 ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
> > create mode 100644 ArmPkg/Drivers/ArmPsciMpServicesDxe/MpServicesInternal.h
> > create mode 100644 ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c
> > create mode 100644 ArmPkg/Drivers/ArmPsciMpServicesDxe/MpFuncs.S
> >
prev parent reply other threads:[~2023-01-27 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 4:57 [PATCH v5 0/2] ArmPkg: Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64 Rebecca Cran
2023-01-17 4:57 ` [PATCH v5 1/2] ArmPkg: Add GET_MPIDR_AFFINITY_BITS and MPIDR_MT_BIT to ArmLib.h Rebecca Cran
2023-01-17 4:57 ` [PATCH v5 2/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls Rebecca Cran
2023-01-24 0:18 ` [PATCH v5 0/2] ArmPkg: Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64 Kun Qin
2023-01-27 4:10 ` [edk2-devel] " Rebecca Cran
2023-01-27 14:02 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXG-hKCgedBsXTsaUfO69Q5v+a2vH=ebSDEktnGqfCx-2A@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox