From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web12.983.1646071990651812056 for ; Mon, 28 Feb 2022 10:13:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CbsHrv44; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A1F5FB815A2 for ; Mon, 28 Feb 2022 18:13:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C088C340E7 for ; Mon, 28 Feb 2022 18:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646071987; bh=cXi19nPdDfeJ7AjUdk1Awz/zX7d0Qdkagapx30SJZeQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CbsHrv44rN3OngNHRhkeeI0XB+VEuz37nyvSieIeyl8hEKXNdBj3/nc0rdZJdnmV4 C6if1EqUyz15l3/TnbUuk4cHfQWJz7jv3s6f4GH0XJf6DH4DjT8mGDgSkiDqwVwOu2 hLApo4NxQii+au96M8jFfbOyuwEJ5WRBnuuSS7QIZNOg8y0AhM+Qlr2zxbwTXEsAu6 jSbd+sR0h15RLTTYYyMfrUALEmwtaUoFi50+3LS3NceEeqTAbJ5j2qyVn22htVA0rf /MLi2Qwt+EQ867SYPAaX2IT/XpAVqbyuUGB5OPis1/yALxZkg6FldUYQ2KlucaOk/1 RFB92Wu1VcQgA== Received: by mail-yb1-f176.google.com with SMTP id b35so22193647ybi.13 for ; Mon, 28 Feb 2022 10:13:07 -0800 (PST) X-Gm-Message-State: AOAM533RBVuop/3LGkeUus+x/vqP5Ves3hJHlOvB7L59fxUZ7w2iiwzy 4DOVG65lI3TvMvrRCbree62D/s5K/yvJIFHWu+A= X-Google-Smtp-Source: ABdhPJy4TUP4dDyXgBZuXlLv/HQUWz69EroSEdw6bfCEsD/S0pfXpbBFyBtHytwHAsZG9nmfxB6R5jI08Dk4CJqhz1U= X-Received: by 2002:a25:58f:0:b0:628:67cd:c6b4 with SMTP id 137-20020a25058f000000b0062867cdc6b4mr1848261ybf.533.1646071986394; Mon, 28 Feb 2022 10:13:06 -0800 (PST) MIME-Version: 1.0 References: <20220228173100.1370142-1-Himanshu.Sharma@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 28 Feb 2022 19:12:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-non-osi][PATCH v2] Drivers/Realtek: Including Realtek driver to enable network support To: Himanshu Sharma Cc: edk2-devel-groups-io , Ard Biesheuvel , Leif Lindholm , Sami Mujawar Content-Type: text/plain; charset="UTF-8" On Mon, 28 Feb 2022 at 19:02, Himanshu Sharma wrote: > > Hello Ard, > Thanks for the comments. > The replies to the asked questions are inline. > > Thanks, > Himanshu > > On Mon, Feb 28, 2022 at 11:13 PM Ard Biesheuvel wrote: > > > > On Mon, 28 Feb 2022 at 18:31, Himanshu Sharma wrote: > > > > > > This patch adds the generic Realtek PCIe UNDI Driver version 2.057 > > > driver binary to edk2-non-osi that can be made available to use for > > > the platforms that use Realtek's network controller > > > > > > This is a Aarch64 binary, available at: > > > https://www.realtek.com/en/directly-download?downloadid=b0c3e46b2831dcab4edfecce06f15a4f > > > > > > Signed-off-by: Himanshu Sharma > > > > Like I asked the previous time, who provide the license text? The fact > > that the file can be downloaded directly doesn't mean we are permitted > > to stick it in the repository and redistribute it. > > The license file has been provided by Realtek. > The email conversation supporting the same is attached with this email > after consulting on the legal standards. > > > Also, you are sending it as a v2. How is it different from v1? > > The license copyright year in v2 is changed to 2020 after the consultation. > Thanks for the clarification. Reviewed-by: Ard Biesheuvel Pushed as c1075e9ddd64..0320db977fb2