Re: [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable

["Ard Biesheuvel" <ardb@kernel.org>]

On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>
> The Secure Partition(SP) can request services from the Secure
> Partition Manager Core(SPMC) either through FF-A calls or through the
> existing SVC calls. Add a feature flag Pcd for enabling the FF-A
> method -- when this is set to FALSE, the SP uses the existing SVC
> calls for making the requests.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> ---
>
> Changes since V4: None
>

Didn't I already ack some of these patches for v3?

In general, please carry over Rb's that have been given on the list if
the patches haven't changed substantially.


>  ArmPkg/ArmPkg.dec | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index f0b136a57a..a8a22c649f 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -84,6 +84,13 @@
>    # hardware coherency (i.e., no virtualization or cache coherent DMA)
>    gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride|FALSE|BOOLEAN|0x00000043
>
> +[PcdsFeatureFlag.AARCH64]
> +  ## Used to select method for requesting services from S-EL1.<BR><BR>
> +  #   TRUE  - Selects FF-A calls for communication between S-EL0 and SPMC.<BR>
> +  #   FALSE - Selects SVC calls for communication between S-EL0 and SPMC.<BR>
> +  # @Prompt Enable FF-A support.
> +  gArmTokenSpaceGuid.PcdFfaEnable|FALSE|BOOLEAN|0x0000005B
> +
>  [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE|BOOLEAN|0x00000006
>
> --
> 2.17.1
>