From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web08.33480.1613990946953803278
 for <devel@edk2.groups.io>;
 Mon, 22 Feb 2021 02:49:07 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XSQmsTpz;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2BACA64E44
	for <devel@edk2.groups.io>; Mon, 22 Feb 2021 10:49:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1613990946;
	bh=BB15ObSUxgqpE8MVJ6tkjZKcBLhI/1cCn0i3AW0kNoA=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=XSQmsTpzQ2KfIxGhUS6oGPO2UuYzVIaaGFF0VXoUQypvwhTuB671pprf1wmnMLYSu
	 IN89cCmSCAE6KhaBG2WLqGLMEvZVnrbZi98HSU3dxTVysOwbh2I9KOSSdzoMl1mvFn
	 KxC9QAW1l86p0PGdJUjrJcRpMd65biucLQB4BMacUKWM+jiEOD0fkxlL3QW33nfjMZ
	 7Dh3WZGk1Cc2kaLkqjb4bJDXUIanc/95J41hv665g9Wvjh9/ogNzSsihP6SkS0geJV
	 3bu3FVDKi8J5bDw5CrLynAO4s8t5z11k3YV/eq90mRzfBYeBPcGzJNG5KuH5eU0BsD
	 NyecLI3COZJDw==
Received: by mail-ot1-f52.google.com with SMTP id c16so11571377otp.0
        for <devel@edk2.groups.io>; Mon, 22 Feb 2021 02:49:06 -0800 (PST)
X-Gm-Message-State: AOAM533hGXRGp5baj1vId2/aOJ3JShES6opog2bRfMCZqitN5BjsDNhc
	ePoGV4zpXMxOdZp08NFvO8Vi67QBMxJWhsdECkA=
X-Google-Smtp-Source: ABdhPJyCsRxhrNBes67tgf0IHKgNSqXYGzUZ0YSlIJF/kFkmqEjT3DXJ6fRiNP0PccuS/bvaOqIa68z9/mYlXUg9++E=
X-Received: by 2002:a9d:42c:: with SMTP id 41mr1742162otc.108.1613990945381;
 Mon, 22 Feb 2021 02:49:05 -0800 (PST)
MIME-Version: 1.0
References: <20210219063607.27920-1-sughosh.ganu@linaro.org> <20210219063607.27920-5-sughosh.ganu@linaro.org>
In-Reply-To: <20210219063607.27920-5-sughosh.ganu@linaro.org>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 22 Feb 2021 11:48:54 +0100
X-Gmail-Original-Message-ID: <CAMj1kXG0dK_7m20WAi7jXa0hyRGKRmRSyudoNzJ_5BnHXWatiA@mail.gmail.com>
Message-ID: <CAMj1kXG0dK_7m20WAi7jXa0hyRGKRmRSyudoNzJ_5BnHXWatiA@mail.gmail.com>
Subject: Re: [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable
To: Sughosh Ganu <sughosh.ganu@linaro.org>
Cc: devel@edk2.groups.io, Sami Mujawar <sami.mujawar@arm.com>, 
	Ilias Apalodimas <ilias.apalodimas@linaro.org>, Ard Biesheuvel <ardb+tianocore@kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>
> The Secure Partition(SP) can request services from the Secure
> Partition Manager Core(SPMC) either through FF-A calls or through the
> existing SVC calls. Add a feature flag Pcd for enabling the FF-A
> method -- when this is set to FALSE, the SP uses the existing SVC
> calls for making the requests.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> ---
>
> Changes since V4: None
>

Didn't I already ack some of these patches for v3?

In general, please carry over Rb's that have been given on the list if
the patches haven't changed substantially.


>  ArmPkg/ArmPkg.dec | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index f0b136a57a..a8a22c649f 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -84,6 +84,13 @@
>    # hardware coherency (i.e., no virtualization or cache coherent DMA)
>    gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride|FALSE|BOOLEAN|0x00000043
>
> +[PcdsFeatureFlag.AARCH64]
> +  ## Used to select method for requesting services from S-EL1.<BR><BR>
> +  #   TRUE  - Selects FF-A calls for communication between S-EL0 and SPMC.<BR>
> +  #   FALSE - Selects SVC calls for communication between S-EL0 and SPMC.<BR>
> +  # @Prompt Enable FF-A support.
> +  gArmTokenSpaceGuid.PcdFfaEnable|FALSE|BOOLEAN|0x0000005B
> +
>  [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE|BOOLEAN|0x00000006
>
> --
> 2.17.1
>