From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.2493.1639776701281632996 for ; Fri, 17 Dec 2021 13:31:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kryY4pZu; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C45D623E7 for ; Fri, 17 Dec 2021 21:31:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B29CC36AEE for ; Fri, 17 Dec 2021 21:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639776699; bh=nDb65b/fCTyNkaBkO/ZMZn2yQhohXnSvXk4yGEOX8as=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kryY4pZug4d+ClzV5XREWIezJrBptlwbx01WN7TtTs2OiY8dMyafksvuUO5b3GCIi KmHMOaHKEgma82gMl7ffuHqSesZxNxbp8qAmT4OlqHZsSKWITR2X1pC7gAx8s945nN d5jenRAcLuHR+2GOxXPaxbNAxhvmGCw+jjcjKxUbCL2bsQt/U185HOjPrhDPkaJtg4 XlLjEg9jHrlGbMXEflVQ0qNrFvSd8chWjraFvSYjaDQqwpFOE2a26LlO+HrhNI0w6A NC39JrMp2AAVbDug1pyAaXJyi3lGhRyd7FVtrImb7vQZU6rswoKcykCy421qyoYy4k hgVG4xfGv18Ag== Received: by mail-wm1-f41.google.com with SMTP id y83-20020a1c7d56000000b003456dfe7c5cso4012315wmc.1 for ; Fri, 17 Dec 2021 13:31:39 -0800 (PST) X-Gm-Message-State: AOAM531N8kzjaX/h2B5GpeCmiH9qUoJaVTbI1pgICThsKWJLwpxJBSrw +F+t3trj5vzYagW/uQ0wElPL12Nu9NoF7d3QmhM= X-Google-Smtp-Source: ABdhPJzS0kj4XmyOV+RQIUvw1luuc7CZIljq3s1OUbDQEr/hIstBPtCL6W/UbhPl2nFTP5f5jEjETY8q6G6JfFbRIww= X-Received: by 2002:a05:600c:4ed2:: with SMTP id g18mr4314292wmq.25.1639776697949; Fri, 17 Dec 2021 13:31:37 -0800 (PST) MIME-Version: 1.0 References: <20211217024140.281271-1-stefanb@linux.ibm.com> <20211217055154.ksyo6omrzgdw4jjh@sirius.home.kraxel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 17 Dec 2021 22:31:26 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case To: Shivanshu Goyal Cc: edk2-devel-groups-io , Gerd Hoffmann , Stefan Berger , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Ard Biesheuvel , Jiewen Yao , Jordan Justen Content-Type: text/plain; charset="UTF-8" On Fri, 17 Dec 2021 at 20:21, Shivanshu Goyal wrote: > > Hi, > > I'm asking on behalf of Arch Linux maintainers: are you planning on creating a new release with this patch, or should we apply this patch ourselves until a new version is released? > Tianocore doesn't do releases, there are only periodic 'stable tags' in the repo, and one such tag was created just a week ago. So if Arch Linux needs this change, it's better to carry it locally for the time being. > > On Fri, Dec 17, 2021, 9:37 AM Ard Biesheuvel wrote: >> >> On Fri, 17 Dec 2021 at 06:52, Gerd Hoffmann wrote: >> > >> > On Thu, Dec 16, 2021 at 09:41:40PM -0500, Stefan Berger wrote: >> > > For GPU passthrough support we have to initialize the console after >> > > EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after >> > > this. This was the calling order before the TCG physical presence support >> > > had to be moved and the console initialized earlier so user interaction >> > > could be supported before processing TCG physical presence opcodes. >> > > >> > > Fixes: b8675deaa819631db2667df63f89799fe65fc906 >> > > Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3771 >> > > Cc: Ard Biesheuvel >> > > Cc: Jiewen Yao >> > > Cc: Jordan Justen >> > > Cc: Gerd Hoffmann >> > > Signed-off-by: Stefan Berger >> > > Tested-by: Shivanshu Goyal >> > >> > > + // >> > > + // GPU passthrough only allows Console enablement after ROM image load >> > > + // >> > > + PlatformInitializeConsole (gPlatformConsole); >> > >> > Ah, fixed already. >> > >> > Acked-by: Gerd Hoffmann >> > >> > take care, >> > Gerd >> > >> >> Merged as #2325 >> >> Thanks all,