From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] Merge commit in edk2-non-osi
Date: Wed, 21 Feb 2024 09:06:40 +0100 [thread overview]
Message-ID: <CAMj1kXG2VtH=dKU6FEd_nQC95Y5U+_k8UJB6BrThNnr_sMu1Mw@mail.gmail.com> (raw)
In-Reply-To: <MW4PR11MB5821A4386082053AF891B650CD572@MW4PR11MB5821.namprd11.prod.outlook.com>
On Wed, 21 Feb 2024 at 02:49, Nate DeSimone
<nathaniel.l.desimone@intel.com> wrote:
>
> Hi Everyone,
>
> It appears that a merge commit was introduced to edk2-non-osi due to a PR merge:
>
> https://github.com/tianocore/edk2-non-osi/commit/61b65fccfe4c75bc9ecb7b542412a436e3db5de6
>
> I would like to remind everyone that we generally don't accept submissions via PRs yet. At the very least please click "Rebase and merge" when closing the PR instead of "Merge pull request". Since that merge commit is currently at the top of the tree, can we delete it?
>
I think force rebasing is fine in this particular case - the file
contents will remain the same, it is just the git history that gets
linearized, so everyone that pulls from it should get the expected
results.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115719): https://edk2.groups.io/g/devel/message/115719
Mute This Topic: https://groups.io/mt/104481195/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-02-21 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 1:49 [edk2-devel] Merge commit in edk2-non-osi Nate DeSimone
2024-02-21 8:06 ` Ard Biesheuvel [this message]
2024-02-21 15:05 ` Michael D Kinney
2024-02-21 23:29 ` Ard Biesheuvel
2024-02-21 23:42 ` Nate DeSimone
2024-02-21 8:57 ` Marcin Juszkiewicz
2024-02-21 15:26 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXG2VtH=dKU6FEd_nQC95Y5U+_k8UJB6BrThNnr_sMu1Mw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox