From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.268.1685639647970532135 for ; Thu, 01 Jun 2023 10:14:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q60Fh8m/; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58BBA6482B for ; Thu, 1 Jun 2023 17:14:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6290EC433AE for ; Thu, 1 Jun 2023 17:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685639646; bh=ZZna4O+GRk5X7XmpWB3qxAFMyYYBwIaLcpWROobhUoo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=q60Fh8m/hdtMlkYaSrUMstMiaf19Xhs5P8WtbrybHNSsANmOiyeg8UpRsmMnTvHBb yWL+Dr2A0IWSIzaIkMRQXRRjlzlnpHWznx881LKt6CLGE3tLU3A9Hqld+t1xvx97th KYla1ST1rpOUxllj53K2KhPjmm/cfr/avx+t8qazE3gBvbKn3L8IbmVkLb0kZDe5fM dhy7fc8P998mxUPVI9vkrLc3kYX41Y+FBvzKpzTjz0nzk7Urx0spxmJusSD0Ehmhyl nI3nxSI3BPzq5Ixp+OByVoUOMYcWBu0kG843ZgB/eBHFKPk8UPXQOxtq/6RgsMEZml 8oAqhqO7wLbug== Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4f3b4ed6fdeso1419114e87.3 for ; Thu, 01 Jun 2023 10:14:06 -0700 (PDT) X-Gm-Message-State: AC+VfDwbQYCkHJBd6iqC8FdzPt4MXeVfhj4r94KZClS+tEKxutOWxMLu ebtOteG3iMaT7EccUBvslhh7puscModRjLVWWf4= X-Google-Smtp-Source: ACHHUZ4Fj3s9/z0jOEdmNBsB3Q19SvhYecZCqub+BRJQvJ4nEJncIck1HWOkaS7tNTkOD8oGfcUBmu1BVu+4f+o22w4= X-Received: by 2002:ac2:5e83:0:b0:4e7:dd1e:e521 with SMTP id b3-20020ac25e83000000b004e7dd1ee521mr397640lfq.9.1685639644157; Thu, 01 Jun 2023 10:14:04 -0700 (PDT) MIME-Version: 1.0 References: <20230509163212.291333-1-pedro.falcato@gmail.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 1 Jun 2023 19:13:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one To: Pedro Falcato Cc: devel@edk2.groups.io, Laszlo Ersek , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , =?UTF-8?Q?Corvin_K=C3=B6hne?= , Sebastien Boeuf , Anthony Perard , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 1 Jun 2023 at 19:12, Pedro Falcato wrote: > > On Thu, Jun 1, 2023 at 5:12=E2=80=AFPM Ard Biesheuvel w= rote: > > > > On Tue, 9 May 2023 at 18:32, Pedro Falcato wr= ote: > > > > > > This patch-set replaces the OVMF specific SataControllerDxe with the = MdeModulePkg/Bus/Pci one. > > > They were both forked from the same code, and are code-and-functional= ity similar. As such, there > > > seems to be no need for duplication here. > > > > > > The first four pages both replay OvmfPkg/SataControllerDxe commits an= d fix up a couple of details. > > > The rest of the patches (minus the last) replace OvmfPkg/SataControll= erDxe with the MdeModulePkg variant. > > > The last patch, finally, removes the thing. > > > > > > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). > > > More testing from other, alternative platforms is desired, although b= reakage seems unlikely. > > > > > > This patchset (or at least, the last patch) depends on the edk2-platf= orms patch series to get merged. > > > > > > (+CC Laszlo as the author of the original SataControllerDxe patches) > > > > > > Cc: Ard Biesheuvel > > > Cc: Jiewen Yao > > > Cc :Jordan Justen > > > Cc: Gerd Hoffmann > > > Cc: Erdem Aktas > > > Cc: James Bottomley > > > Cc: Min Xu > > > Cc: Tom Lendacky > > > Cc: Michael Roth > > > Cc: Rebecca Cran > > > Cc: Peter Grehan > > > Cc: Corvin K=C3=B6hne > > > Cc: Sebastien Boeuf > > > Cc: Anthony Perard > > > Cc: Julien Grall > > > Cc: Laszlo Ersek > > > > > > Changes: > > > v2: > > > - Address Laszlo's feedback wrt commit to port into MdeModulePkg > > > - Address Laszlo's feedback wrt how to split the removal of the dri= ver and the patches for each sub-platform maintainer > > > - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Pri= vate !=3D NULL) > > > - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12= (since they are remotely QEMU related) > > > > > > Pedro Falcato (12): > > > MdeModulePkg/SataControllerDxe: Clean up error handling in Start() > > > MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO > > > level > > > MdeModulePkg/SataControllerDxe: Remove useless null check > > > MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private !=3D NULL) > > > OvmfPkg: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg: Remove SataControllerDxe > > > > > > > What is the state of this series? > > > > Are we waiting for the MdeModulePkg changes to be picked up, and do > > the OVMF changes have to wait for that? > > Hi Ard, > > I believe we've got the appropriate reviews/acks from the relevant > people for both MdeModulePkg and OvmfPkg. > > I've just updated my PR with the appropriate tags on each commit: > https://github.com/tianocore/edk2/pull/4370 > In that case, please send it out again, and I'll go and merge it. Thanks,