From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web10.106590.1680625761479979771
 for <devel@edk2.groups.io>;
 Tue, 04 Apr 2023 09:29:21 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HfyUkeg2;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id D0D1663253
	for <devel@edk2.groups.io>; Tue,  4 Apr 2023 16:29:20 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 460CCC433EF
	for <devel@edk2.groups.io>; Tue,  4 Apr 2023 16:29:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1680625760;
	bh=IU/SlbpXdbnOxZTijc7m/wv1r/OFDI/ayR5mV18kNlc=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=HfyUkeg221MbmZAodDY2i8XG9AgjXbOr+ARLckKH0gbZbOPj4ARCHs1oJHsIx0edq
	 Ri/+hkjNStIWUvB8lT/SoQF1n1taFeb6UxU0HsMup1j6Qn/xo/VczlNxuCDdS1oyoy
	 ySHwaXLMZau2rFLAQp+4zIgxJFpQtfU28lYsHW71zdAd+gt79SgQAwsvhgcaAfQOiC
	 uKiz71JQzXK/3CZX7X4X1ZdKvpIGJSiHQHygReNu1H5N8c/o1EsW35oW2dLIuNeLJ6
	 DfhJ7s0J9TMGizP3ubYsR1jyyET+lZ0IEFCgfpHbsYooHS1KKLvxGBEzNoUq062+Qf
	 du863iVvNoGQQ==
Received: by mail-lf1-f44.google.com with SMTP id y20so43111378lfj.2
        for <devel@edk2.groups.io>; Tue, 04 Apr 2023 09:29:20 -0700 (PDT)
X-Gm-Message-State: AAQBX9cm+5fw1G+x66MKvR2BxBRRz3e70osRofALCvnNd2rqu49sC8Jy
	nkyHEeQZICUWOWUyqDWC1eC4G3Sac7ScfRsbIt0=
X-Google-Smtp-Source: AKy350YwQ3G6PptDUiw8GncD5OkkNX8cl/uZ2ZsuCAwRpjaBN/sOmZc/8SKJ0t4QMGH8OdZUJa93+yK++ZKqzi/mMWc=
X-Received: by 2002:a05:6512:68:b0:4eb:3f68:553f with SMTP id
 i8-20020a056512006800b004eb3f68553fmr900646lfo.9.1680625758278; Tue, 04 Apr
 2023 09:29:18 -0700 (PDT)
MIME-Version: 1.0
References: <20230404154022.2776035-1-ardb@kernel.org> <09AB600D-DDCC-4FF4-B73B-4647C7E0A95B@posteo.de>
In-Reply-To: <09AB600D-DDCC-4FF4-B73B-4647C7E0A95B@posteo.de>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Tue, 4 Apr 2023 18:29:07 +0200
X-Gmail-Original-Message-ID: <CAMj1kXG2zXNdz6G_sVpWNM=nx-WF0Eb=gaUdSZPYyqJwWJ3-fg@mail.gmail.com>
Message-ID: <CAMj1kXG2zXNdz6G_sVpWNM=nx-WF0Eb=gaUdSZPYyqJwWJ3-fg@mail.gmail.com>
Subject: Re: [PATCH v3 0/4] Enable BTI support in memory attributes table
To: =?UTF-8?Q?Marvin_H=C3=A4user?= <mhaeuser@posteo.de>
Cc: devel@edk2.groups.io, Michael Kinney <michael.d.kinney@intel.com>, 
	Liming Gao <gaoliming@byosoft.com.cn>, Jiewen Yao <jiewen.yao@intel.com>, 
	Michael Kubacki <Michael.Kubacki@microsoft.com>, Sean Brogan <sean.brogan@microsoft.com>, 
	Rebecca Cran <quic_rcran@quicinc.com>, Leif Lindholm <quic_llindhol@quicinc.com>, 
	Sami Mujawar <sami.mujawar@arm.com>, Taylor Beebe <t@taylorbeebe.com>, 
	Bob Feng <bob.c.feng@intel.com>, Oliver Smith-Denny <osde@linux.microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 4 Apr 2023 at 18:19, Marvin H=C3=A4user <mhaeuser@posteo.de> wrote:
>
> FWIW, Reviewed-by: Marvin H=C3=A4user <mhaeuser@posteo.de>
>
> An off-topic remark, but I find it ominous that when adding a hack like t=
he DllCharacteristicsEx debug entry, the opportunity is not used to turn it=
 into something that can be expanded in the future without introducing yet =
another hack like this (I know 31 more Bits look plenty now, but if an addr=
ess, offset, or size will be needed=E2=80=A6 ouch).
>

It *can* be expanded in the future. The debug directory entry includes
a size field, and once flags get defined that are not present, they
just default to unset.