From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, rebecca@bsdio.com
Cc: Nhi Pham <nhi@os.amperecomputing.com>,
Vu Nguyen <vunguyen@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Chuong Tran <chuong@os.amperecomputing.com>,
Leif Lindholm <quic_llindhol@quicinc.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message
Date: Mon, 7 Aug 2023 08:53:15 +0200 [thread overview]
Message-ID: <CAMj1kXG4QO4CbSdV8pUT=Oafhs2Z2_m8jXMk4VEzf2zUy42PZw@mail.gmail.com> (raw)
In-Reply-To: <20230807015546.448690-1-rebecca@bsdio.com>
On Mon, 7 Aug 2023 at 03:56, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> There's an extra format specifier in the DEBUG_ERROR message that
> gets printed when the PCIe link check fails. This causes a
> synchronous exception. Remove the string format specifier.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Thanks
Pushed as 4507df44c528..84ccada59257
> ---
> Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
> index 94eb9e27d203..3c1fe5e35ca2 100644
> --- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
> +++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
> @@ -1405,7 +1405,7 @@ PFACounterRead (
> Ret = LINK_CHECK_FAILED;
> DEBUG ((
> DEBUG_ERROR,
> - "\tSocket%d RootComplex%d RP%d \t%s: %d \tGROUP:%d-EVENT:%d\n",
> + "\tSocket%d RootComplex%d RP%d \t: %d \tGROUP:%d-EVENT:%d\n",
> RootComplex->Socket,
> RootComplex->ID,
> PcieIndex,
> --
> 2.34.1
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107610): https://edk2.groups.io/g/devel/message/107610
Mute This Topic: https://groups.io/mt/100592555/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-08-07 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 1:55 [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message Rebecca Cran
2023-08-07 6:53 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXG4QO4CbSdV8pUT=Oafhs2Z2_m8jXMk4VEzf2zUy42PZw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox