From: "Ard Biesheuvel" <ardb@kernel.org>
To: Thomas Abraham <thomas.abraham@arm.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt
Date: Wed, 22 Jun 2022 19:33:01 +0200 [thread overview]
Message-ID: <CAMj1kXG5=1jRkL7FmzeW=CNxwWnP=np=y0d=aukYaJW+YYQV0g@mail.gmail.com> (raw)
In-Reply-To: <20220622153843.15003-1-thomas.abraham@arm.com>
On Wed, 22 Jun 2022 at 17:38, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> For Arm platforms that support more that one serial port, one of the
> serial port can be used for connecting debuggers such as WinDbg. There
> are PCDs that allow the base address and clock rate to be specified for
> this debug serial port but not its interrupt number. So add a PCD to
> specify the interrupt number assigned to the serial debug port
> controller.
>
> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
> ---
> ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
> 1 file changed, 1 insertion(+)
>
> Changes since v1
> - Updated commit message and removed the Change-Id line as suggested by
> Ard.
>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Merged as #3001.
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
> index 3a25ddcdc8..dd6e78f62a 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
> @@ -94,6 +94,7 @@
> gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
> gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
> gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
> + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>
> ## PL061 GPIO
> gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
> --
> 2.17.1
>
prev parent reply other threads:[~2022-06-22 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 15:38 [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt Thomas Abraham
2022-06-22 17:33 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXG5=1jRkL7FmzeW=CNxwWnP=np=y0d=aukYaJW+YYQV0g@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox