From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web12.10291.1655919198545184857 for ; Wed, 22 Jun 2022 10:33:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nXo3s01X; spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 82967CE2203 for ; Wed, 22 Jun 2022 17:33:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA4D0C385A5 for ; Wed, 22 Jun 2022 17:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655919193; bh=g+rJar8XR14p553QF+cDCVmPQ1LLDMP6GPx3L1MTUYo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nXo3s01Xm0AUQRWOmlNv16mEJpI2uyRLBLc/wjZc7CWqDslI5ceHbpYpR5xgtjK95 S5zMQ4lKC0z5I+eSYcP8heaiO2dHejkMHSEl+TUw7r9AEM5bwkSSHFVvVyXP1goOUM 5mibP2V0f2Xjch8KGg21Cq8zCAvKgdORPMhMW3zJKmQvPdC6u/I02ZsCL4QybVotmi +rjg/v4cWP+D8w6kv6CVyEtx06DkhKeShJGkvQ7ko7ZTlwbXV6gCiya6BtXRwByTyn iq+eBJJO0JR7ujFKciMk02xiNmduQmxE67jIeRi1PSxak3rtiguYWaG7fJ+FOxKELE N7G1ZboS4cz7w== Received: by mail-oi1-f180.google.com with SMTP id e131so1958909oif.13 for ; Wed, 22 Jun 2022 10:33:13 -0700 (PDT) X-Gm-Message-State: AJIora8r0/EqGU/njpMQh2EPv0CkZJP7X7mm/6iyzsYOikngcROmcqc2 uwjksuskOtDD/9pJ2k4MOf9FH4Noe9qOgAMaV6I= X-Google-Smtp-Source: AGRyM1uf4pGHfXDF01SHHe7Lw0oiuaUZprEvPx2+WpWrbnF0qQusYzzQoMg5N5n8O/Z/5ag5ieA76dzu0tYSDAVSf6k= X-Received: by 2002:a05:6808:b19:b0:335:244d:6f8a with SMTP id s25-20020a0568080b1900b00335244d6f8amr607687oij.228.1655919192972; Wed, 22 Jun 2022 10:33:12 -0700 (PDT) MIME-Version: 1.0 References: <20220622153843.15003-1-thomas.abraham@arm.com> In-Reply-To: <20220622153843.15003-1-thomas.abraham@arm.com> From: "Ard Biesheuvel" Date: Wed, 22 Jun 2022 19:33:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt To: Thomas Abraham Cc: edk2-devel-groups-io , Ard Biesheuvel , Leif Lindholm , Sami Mujawar Content-Type: text/plain; charset="UTF-8" On Wed, 22 Jun 2022 at 17:38, Thomas Abraham wrote: > > For Arm platforms that support more that one serial port, one of the > serial port can be used for connecting debuggers such as WinDbg. There > are PCDs that allow the base address and clock rate to be specified for > this debug serial port but not its interrupt number. So add a PCD to > specify the interrupt number assigned to the serial debug port > controller. > > Signed-off-by: Thomas Abraham > --- > ArmPlatformPkg/ArmPlatformPkg.dec | 1 + > 1 file changed, 1 insertion(+) > > Changes since v1 > - Updated commit message and removed the Change-Id line as suggested by > Ard. > Reviewed-by: Ard Biesheuvel Merged as #3001. > diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec > index 3a25ddcdc8..dd6e78f62a 100644 > --- a/ArmPlatformPkg/ArmPlatformPkg.dec > +++ b/ArmPlatformPkg/ArmPlatformPkg.dec > @@ -94,6 +94,7 @@ > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030 > gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031 > gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032 > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041 > > ## PL061 GPIO > gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025 > -- > 2.17.1 >