* [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt
@ 2022-06-22 15:38 Thomas Abraham
2022-06-22 17:33 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Abraham @ 2022-06-22 15:38 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Sami Mujawar
For Arm platforms that support more that one serial port, one of the
serial port can be used for connecting debuggers such as WinDbg. There
are PCDs that allow the base address and clock rate to be specified for
this debug serial port but not its interrupt number. So add a PCD to
specify the interrupt number assigned to the serial debug port
controller.
Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
---
ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
1 file changed, 1 insertion(+)
Changes since v1
- Updated commit message and removed the Change-Id line as suggested by
Ard.
diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index 3a25ddcdc8..dd6e78f62a 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -94,6 +94,7 @@
gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
+ gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
## PL061 GPIO
gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt
2022-06-22 15:38 [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt Thomas Abraham
@ 2022-06-22 17:33 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2022-06-22 17:33 UTC (permalink / raw)
To: Thomas Abraham
Cc: edk2-devel-groups-io, Ard Biesheuvel, Leif Lindholm, Sami Mujawar
On Wed, 22 Jun 2022 at 17:38, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> For Arm platforms that support more that one serial port, one of the
> serial port can be used for connecting debuggers such as WinDbg. There
> are PCDs that allow the base address and clock rate to be specified for
> this debug serial port but not its interrupt number. So add a PCD to
> specify the interrupt number assigned to the serial debug port
> controller.
>
> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
> ---
> ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
> 1 file changed, 1 insertion(+)
>
> Changes since v1
> - Updated commit message and removed the Change-Id line as suggested by
> Ard.
>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Merged as #3001.
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
> index 3a25ddcdc8..dd6e78f62a 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
> @@ -94,6 +94,7 @@
> gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
> gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
> gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
> + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>
> ## PL061 GPIO
> gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-22 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-22 15:38 [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt Thomas Abraham
2022-06-22 17:33 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox