public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] OvmfPkg/CI: Boot OVMF in SMP mode.
@ 2023-03-27 15:01 Gerd Hoffmann
  2023-03-29 16:00 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2023-03-27 15:01 UTC (permalink / raw)
  To: devel
  Cc: Pawel Polawski, Jiewen Yao, Ard Biesheuvel, Gerd Hoffmann,
	Oliver Steffen, Jordan Justen

Increase the chance that CI finds bugs in MP changes.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 OvmfPkg/PlatformCI/PlatformBuildLib.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py
index 58dc1189a2cc..1ff85fdc24bb 100644
--- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
+++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
@@ -196,6 +196,7 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
         args  = "-debugcon stdio"                                           # write messages to stdio
         args += " -global isa-debugcon.iobase=0x402"                        # debug messages out thru virtual io port
         args += " -net none"                                                # turn off network
+        args += " -smp 4"
         args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh
 
         if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):
@@ -204,7 +205,6 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
         if (self.env.GetBuildValue("SMM_REQUIRE") == "1"):
             args += " -machine q35,smm=on" #,accel=(tcg|kvm)"
             #args += " -m ..."
-            #args += " -smp ..."
             args += " -global driver=cfi.pflash01,property=secure,value=on"
             args += " -drive if=pflash,format=raw,unit=0,file=" + os.path.join(OutputPath_FV, "OVMF_CODE.fd") + ",readonly=on"
             args += " -drive if=pflash,format=raw,unit=1,file=" + os.path.join(OutputPath_FV, "OVMF_VARS.fd")
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] OvmfPkg/CI: Boot OVMF in SMP mode.
  2023-03-27 15:01 [PATCH 1/1] OvmfPkg/CI: Boot OVMF in SMP mode Gerd Hoffmann
@ 2023-03-29 16:00 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2023-03-29 16:00 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: devel, Pawel Polawski, Jiewen Yao, Ard Biesheuvel, Oliver Steffen,
	Jordan Justen

On Mon, 27 Mar 2023 at 17:02, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Increase the chance that CI finds bugs in MP changes.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Merged as #4205

Thanks

> ---
>  OvmfPkg/PlatformCI/PlatformBuildLib.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> index 58dc1189a2cc..1ff85fdc24bb 100644
> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> @@ -196,6 +196,7 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
>          args  = "-debugcon stdio"                                           # write messages to stdio
>          args += " -global isa-debugcon.iobase=0x402"                        # debug messages out thru virtual io port
>          args += " -net none"                                                # turn off network
> +        args += " -smp 4"
>          args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh
>
>          if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):
> @@ -204,7 +205,6 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
>          if (self.env.GetBuildValue("SMM_REQUIRE") == "1"):
>              args += " -machine q35,smm=on" #,accel=(tcg|kvm)"
>              #args += " -m ..."
> -            #args += " -smp ..."
>              args += " -global driver=cfi.pflash01,property=secure,value=on"
>              args += " -drive if=pflash,format=raw,unit=0,file=" + os.path.join(OutputPath_FV, "OVMF_CODE.fd") + ",readonly=on"
>              args += " -drive if=pflash,format=raw,unit=1,file=" + os.path.join(OutputPath_FV, "OVMF_VARS.fd")
> --
> 2.39.2
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-29 16:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-27 15:01 [PATCH 1/1] OvmfPkg/CI: Boot OVMF in SMP mode Gerd Hoffmann
2023-03-29 16:00 ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox