public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Yu Pu <yu.pu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	 Sami Mujawar <sami.mujawar@arm.com>,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [PATCH v1 4/7] StandaloneMmPkg: Invoke GetPhysicalAddressBits() and remove the duplicated code
Date: Thu, 3 Mar 2022 09:58:20 +0000	[thread overview]
Message-ID: <CAMj1kXG7HtZEgtJg3LwtAmVQBLKGh-vpiQmDhKeg4d-KR9K7XA@mail.gmail.com> (raw)
In-Reply-To: <20220302091859.2783-5-yu.pu@intel.com>

On Wed, 2 Mar 2022 at 09:20, Yu Pu <yu.pu@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394
>
> Invoke GetPhysicalAddressBits() defined in UefiCpuPkg for CPU physical address
> mask calculation and remove the duplicated code in
> StandaloneMmPkg\Library\StandaloneMmMemLib\X86StandaloneMmMemLibInternal.c
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> Signed-off-by: Yu Pu <yu.pu@intel.com>
> ---
>  StandaloneMmPkg/Library/StandaloneMmMemLib/X86StandaloneMmMemLibInternal.c | 10 ++--------
>  StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf          |  2 ++
>  StandaloneMmPkg/StandaloneMmPkg.dsc                                        |  1 +
>  3 files changed, 5 insertions(+), 8 deletions(-)
>
...
> diff --git a/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf b/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
> index b29d97a74607..94f7fbb1c4f7 100644
> --- a/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
> +++ b/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
> @@ -43,12 +43,14 @@
>  [Packages]
>    MdePkg/MdePkg.dec
>    StandaloneMmPkg/StandaloneMmPkg.dec
> +  UefiCpuPkg/UefiCpuPkg.dec
>
>  [LibraryClasses]
>    BaseMemoryLib
>    DebugLib
>    HobLib
>    MemoryAllocationLib
> +  UefiCpuLib
>

Isn't this dependency X86 only?

  reply	other threads:[~2022-03-03  9:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02  9:18 [PATCH v1 0/7] *** SUBJECT HERE *** Yu Pu
2022-03-02  9:18 ` [PATCH v1 1/7] UefiCpuPackage: Add APIs for CPU physical address mask calculation Yu Pu
2022-03-02  9:18 ` [PATCH v1 2/7] MdeModulePkg: Invoke GetPhysicalAddressBits() and remove the duplicated code Yu Pu
2022-03-07  3:54   ` [edk2-devel] " Ni, Ray
2022-03-10  8:47     ` Pu, Yu
2022-03-11  1:02       ` 回复: " gaoliming
2022-03-02  9:18 ` [PATCH v1 3/7] IntelFsp2Pkg: " Yu Pu
2022-03-02  9:26   ` Chiu, Chasel
2022-03-02  9:18 ` [PATCH v1 4/7] StandaloneMmPkg: " Yu Pu
2022-03-03  9:58   ` Ard Biesheuvel [this message]
2022-03-04  7:39     ` [edk2-devel] " Ni, Ray
2022-03-02  9:18 ` [PATCH v1 5/7] OvmfPkg: " Yu Pu
2022-03-02  9:18 ` [PATCH v1 6/7] EmulatorPkg: fixed a bug caused by Invoking GetPhysicalAddressBits() Yu Pu
2022-03-02  9:18 ` [PATCH v1 7/7] UefiPayloadPkg: Invoke GetPhysicalAddressBits() and remove the duplicated code Yu Pu
2022-03-04 18:09   ` Guo Dong
     [not found]   ` <16D93FE5C3E39310.28436@groups.io>
2022-03-05  3:43     ` [edk2-devel] " Guo Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXG7HtZEgtJg3LwtAmVQBLKGh-vpiQmDhKeg4d-KR9K7XA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox