From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web11.9085.1646301514014425668
 for <devel@edk2.groups.io>;
 Thu, 03 Mar 2022 01:58:34 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZRfjamv6;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 13B9360F66
	for <devel@edk2.groups.io>; Thu,  3 Mar 2022 09:58:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7581FC36AE2
	for <devel@edk2.groups.io>; Thu,  3 Mar 2022 09:58:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1646301512;
	bh=dFv+0wH3jS+CxJXpGoHtA85+Z1+Wyw928XoP8eYEAxg=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=ZRfjamv6mHmvXhrLJ0sFXDwAVNT4cExXCdFoZ/ZGEtYzmcmAH3at7evbFGJhML4n4
	 5xks3hAfwa7aZglwnpewwp4JiR2WfWZFHld8VqB/JaL/zxr/686C07ToTL3sifEvqu
	 axIhfKc5u5recnNKjFO2Dc6dFpBuVDC4KJHvr7lzURiFsp55UtuPmahRM12wGt1Ay8
	 zKMyy1dUZ/ALBPIwU2EfKrMC7Fbrv8sRubKe8oAYswb4meEyucVZ1zwH8rlC0rL7lO
	 7dfcKOkYXqxordjkbHisrk1RWZYzf+btw/W1O70C9ceuMRoSsUNF9u0ZmN1PZ8f2B0
	 6ok33/audfvpA==
Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-2db569555d6so49060757b3.12
        for <devel@edk2.groups.io>; Thu, 03 Mar 2022 01:58:32 -0800 (PST)
X-Gm-Message-State: AOAM530yhX6wjV0upcWg8YugGFbRdp/yM7qgEFEkmtQ7O0x3rh9N4uM/
	KJUnjPn+IbAxP+ZTHMqQlti3toSD46aMIr3DGKY=
X-Google-Smtp-Source: ABdhPJzJj0mqOppKeZwgeVb7WrXTnPWWmwY9saNeh0K5SVFFskEsDx+xnACKW5CtKuYqygeWq62Lp5Fc87kBzxF6zn4=
X-Received: by 2002:a81:4c57:0:b0:2dc:c7e:605c with SMTP id
 z84-20020a814c57000000b002dc0c7e605cmr6938794ywa.342.1646301511413; Thu, 03
 Mar 2022 01:58:31 -0800 (PST)
MIME-Version: 1.0
References: <20220302091859.2783-1-yu.pu@intel.com> <20220302091859.2783-5-yu.pu@intel.com>
In-Reply-To: <20220302091859.2783-5-yu.pu@intel.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Thu, 3 Mar 2022 09:58:20 +0000
X-Gmail-Original-Message-ID: <CAMj1kXG7HtZEgtJg3LwtAmVQBLKGh-vpiQmDhKeg4d-KR9K7XA@mail.gmail.com>
Message-ID: <CAMj1kXG7HtZEgtJg3LwtAmVQBLKGh-vpiQmDhKeg4d-KR9K7XA@mail.gmail.com>
Subject: Re: [PATCH v1 4/7] StandaloneMmPkg: Invoke GetPhysicalAddressBits() and remove the duplicated code
To: Yu Pu <yu.pu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Sami Mujawar <sami.mujawar@arm.com>, Jiewen Yao <jiewen.yao@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 2 Mar 2022 at 09:20, Yu Pu <yu.pu@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394
>
> Invoke GetPhysicalAddressBits() defined in UefiCpuPkg for CPU physical address
> mask calculation and remove the duplicated code in
> StandaloneMmPkg\Library\StandaloneMmMemLib\X86StandaloneMmMemLibInternal.c
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> Signed-off-by: Yu Pu <yu.pu@intel.com>
> ---
>  StandaloneMmPkg/Library/StandaloneMmMemLib/X86StandaloneMmMemLibInternal.c | 10 ++--------
>  StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf          |  2 ++
>  StandaloneMmPkg/StandaloneMmPkg.dsc                                        |  1 +
>  3 files changed, 5 insertions(+), 8 deletions(-)
>
...
> diff --git a/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf b/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
> index b29d97a74607..94f7fbb1c4f7 100644
> --- a/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
> +++ b/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
> @@ -43,12 +43,14 @@
>  [Packages]
>    MdePkg/MdePkg.dec
>    StandaloneMmPkg/StandaloneMmPkg.dec
> +  UefiCpuPkg/UefiCpuPkg.dec
>
>  [LibraryClasses]
>    BaseMemoryLib
>    DebugLib
>    HobLib
>    MemoryAllocationLib
> +  UefiCpuLib
>

Isn't this dependency X86 only?