From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.9710.1643481759867248368 for ; Sat, 29 Jan 2022 10:42:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p75RFGCO; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 53C8E60E95 for ; Sat, 29 Jan 2022 18:42:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CF1CC340EE for ; Sat, 29 Jan 2022 18:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643481758; bh=JF1UuRv7P4zSXNUE/RmcYI8iVPyUuISGY5GsW1lkels=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=p75RFGCOweYiSZRfKjmusvcmB8klMgflhYx/HnAB+SbHTH23AtZbjsy5RHVFPgEAH lU9Fes5aW8Dm8XLD0msyBLlNocnpT/TkNkMaONrISvOu/PqBVSqjuScPzwBZkk9MDI 9P0GIGEQv9FKqkKbqS6czA5XELYS2o4PXZMqQXfEAg0PDB4Sr38ZifFxvFKX20AWeB 9LHc1s9bE3A5l72x/uWnQQUMCNN7NowCthy5f0WPDGnzVlEWCgiiDEgZaYnVc9CuqZ 0H9kw1ZvMvBFeoDGW0m3ZtitpEVTFiIzI2Qph81NB8msnrUQZOsE+/IoK6z9A7ns3M ZgWSeEjE/M6aw== Received: by mail-wr1-f51.google.com with SMTP id s9so17234275wrb.6 for ; Sat, 29 Jan 2022 10:42:38 -0800 (PST) X-Gm-Message-State: AOAM530k2z/67bVAhvVJoNMG/2QhjSiH5nMHDAE6JunYx+u7+4SM80Gg o3TbsDteZkDIgjFit460BxUwmoqSejmeTlZ1Sag= X-Google-Smtp-Source: ABdhPJzQMM00ZP8HN2PWmo7XgB5tx5qcPohv2c8Nz57bQ7xMOyVj2TsKs96Yo01mVdppryrA0PAr9AbtbuveKy01ZCs= X-Received: by 2002:a05:6000:15ca:: with SMTP id y10mr11322320wry.417.1643481756971; Sat, 29 Jan 2022 10:42:36 -0800 (PST) MIME-Version: 1.0 References: <20220129160348.3247-1-abner.chang@hpe.com> <20220129160348.3247-2-abner.chang@hpe.com> In-Reply-To: <20220129160348.3247-2-abner.chang@hpe.com> From: "Ard Biesheuvel" Date: Sat, 29 Jan 2022 19:42:25 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: Migrate BaseCachingPciExpressLib To: edk2-devel-groups-io , Abner Chang Cc: Daniel Schaefer , Sunil V L , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" On Sat, 29 Jan 2022 at 18:05, Abner Chang wrote: > > Move BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg. > RISC-V Virt platform can leverage the same library to access PCI Express > registers through PCI Express base address set in PcdPciExpressBaseAddress > and cached in a global variable. > > Signed-off-by: Abner Chang > Cc: Daniel Schaefer > Cc: Sunil V L > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > ArmVirtPkg/ArmVirtKvmTool.dsc | 6 +++--- > .../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 0 > .../Library/BaseCachingPciExpressLib/PciExpressLib.c | 0 > 4 files changed, 4 insertions(+), 4 deletions(-) > rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf (100%) > rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%) Acked-by: Ard Biesheuvel Pushed as #2456 with the INF [Packages] reference to ArmVirtPkg.dec dropped, and RISCV64 added to the INF VALID_ARCHITECTURES declaration. > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 5a1598d90c..4db8ad5a79 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -141,7 +141,7 @@ > > # PCI Libraries > PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf > - PciExpressLib|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > + PciExpressLib|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > PciCapLib|OvmfPkg/Library/BasePciCapLib/BasePciCapLib.inf > PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf > PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf > diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc > index 9d23072d8f..4a54d13735 100644 > --- a/ArmVirtPkg/ArmVirtKvmTool.dsc > +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc > @@ -339,17 +339,17 @@ > ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf { > > NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > - NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > + NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > } > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { > > NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > - NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > + NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > } > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf { > > NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > - NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > + NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > } > OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf > OvmfPkg/Virtio10Dxe/Virtio10.inf > diff --git a/ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > similarity index 100% > rename from ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > rename to OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > diff --git a/ArmVirtPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c b/OvmfPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c > similarity index 100% > rename from ArmVirtPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c > rename to OvmfPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c > -- > 2.31.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#86212): https://edk2.groups.io/g/devel/message/86212 > Mute This Topic: https://groups.io/mt/88770178/5717338 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org] > ------------ > >