Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

["Ard Biesheuvel" <ardb@kernel.org>]

On Sat, 20 Feb 2021 at 17:11, Samer El-Haj-Mahmoud
<samer.el-haj-mahmoud@arm.com> wrote:
>
> Resending with Ard's new e-mail address
>

Thanks Samer, but I cannot apply it from the garbled mess below.

Can you please send directly to me with git send-email?

>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer
> > El-Haj-Mahmoud via groups.io
> > Sent: Wednesday, January 6, 2021 9:37 AM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Pete Batard
> > <pete@akeo.ie>; Leif Lindholm <leif@nuviainc.com>; Samer El-Haj-
> > Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
> >
> > resent
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > > Sent: Wednesday, January 6, 2021 5:34 AM
> > > To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Pete
> > Batard
> > > <pete@akeo.ie>; devel@edk2.groups.io; Leif Lindholm
> > > <leif@nuviainc.com>
> > > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> > verbosity
> > >
> > > On 1/5/21 9:46 PM, Samer El-Haj-Mahmoud wrote:
> > > > Gentle reminder...
> > > >
> > >
> > > Please resend this with me on cc so I have it in my mailbox.
> > >
> > > >> -----Original Message-----
> > > >> From: Pete Batard <pete@akeo.ie>
> > > >> Sent: Wednesday, December 23, 2020 11:37 AM
> > > >> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
> > > >> devel@edk2.groups.io
> > > >> Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel
> > > >> <Ard.Biesheuvel@arm.com>
> > > >> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > > >> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> > > verbosity
> > > >>
> > > >> On 2020.12.20 19:14, Samer El-Haj-Mahmoud wrote:
> > > >>> Using Ard's correct e-mail
> > > >>>
> > > >>>> -----Original Message-----
> > > >>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > >> Samer
> > > >>>> El-Haj-Mahmoud via groups.io
> > > >>>> Sent: Sunday, December 20, 2020 2:08 PM
> > > >>>> To: devel@edk2.groups.io
> > > >>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
> > > >>>> <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
> > > >>>> Subject: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > > >>>> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> > > >> verbosity
> > > >>>>
> > > >>>> the DEBUG message for using compilation time epoch is appearing
> > > >>>> very frequently on DEBUG firmware builds, for example during UEFI
> > > SCT runs.
> > > >>>> Reduce verbosity to avoid the annoying repetitive message.
> > > >>>>
> > > >>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > >>>> Cc: Leif Lindholm <leif@nuviainc.com>
> > > >>>> Cc: Pete Batard <pete@akeo.ie>
> > > >>>> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> > > >> Mahmoud@arm.com>
> > > >>>> ---
> > > >>>>
> > > >>>>
> > > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > > >>>> .c
> > > >>>> |
> > > >>>> 2 +-
> > > >>>>   1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>>>
> > > >>>> diff --git
> > > >>>>
> > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL
> > > >>>> ib
> > > >>>> .c
> > > >>>>
> > > >>
> > > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > > >>>> .c index 5c13ed4cf190..4210708cff36 100644
> > > >>>> ---
> > > >>>>
> > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL
> > > >>>> ib
> > > >>>> .c
> > > >>>> +++
> > > >>>>
> > > >>
> > > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > > >>>> .c
> > > >>>> @@ -88,7 +88,7 @@ LibGetTime (
> > > >>>>       //
> > > >>>>
> > > >>>>       EpochSeconds = BUILD_EPOCH;
> > > >>>>
> > > >>>>       DEBUG ((
> > > >>>>
> > > >>>> -      DEBUG_INFO,
> > > >>>>
> > > >>>> +      DEBUG_VERBOSE,
> > > >>>>
> > > >>>>         "LibGetTime: %s non volatile variable was not found -
> > > >>>> Using compilation time epoch.\n",
> > > >>>>
> > > >>>>         mEpochVariableName
> > > >>>>
> > > >>>>         ));
> > > >>>>
> > > >>>> --
> > > >>>> 2.25.1
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>> -=-=-=-=-=-=
> > > >>>> Groups.io Links: You receive all messages sent to this group.
> > > >>>> View/Reply Online (#69269):
> > > >>>> https://edk2.groups.io/g/devel/message/69269
> > > >>>> Mute This Topic: https://groups.io/mt/79110001/1945644
> > > >>>> Group Owner: devel+owner@edk2.groups.io
> > > >>>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> > > >>>> mahmoud@arm.com] -=-=-=-=-=-=
> > > >>>>
> > > >>>
> > > >>> IMPORTANT NOTICE: The contents of this email and any attachments
> > > >>> are
> > > >> confidential and may also be privileged. If you are not the
> > > >> intended recipient, please notify the sender immediately and do not
> > > >> disclose the contents to any other person, use it for any purpose,
> > > >> or store or copy the information in any medium. Thank you.
> > > >>>
> > > >>
> > > >> Reviewed-by: Pete Batard <pete@akeo.ie>
> > > >> Tested-by: Pete Batard <pete@akeo.ie> (On an RPi4 platform where
> > we
> > > >> would see tons of these unwanted messages without this patch)
> > > >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended recipient,
> > please notify the sender immediately and do not disclose the contents to any
> > other person, use it for any purpose, or store or copy the information in any
> > medium. Thank you.
> >
> >
> >
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
>
> 
>
>