From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Peter Grehan <grehan@freebsd.org>
Subject: Re: [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field
Date: Tue, 21 Dec 2021 17:31:49 +0100 [thread overview]
Message-ID: <CAMj1kXG9Np4P+ky=2pVT2iiGfG2osRMwB2Rg07O0Rv8XiZXUNw@mail.gmail.com> (raw)
In-Reply-To: <20211221150642.11747-1-rebecca@bsdio.com>
On Tue, 21 Dec 2021 at 16:06, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> According to the ACPI Specification version 6.0 and newer, the SSDT
> Revision field should be 2. Fix AcpiTables/Ssdt.aml.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
> index 175ab3b7e66d..761b8267b9a5 100644
> --- a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
> +++ b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
> @@ -11,5 +11,5 @@
>
> **/
>
> -DefinitionBlock ("Ssdt.aml", "SSDT", 1, "REDHAT", "OVMF ", 1) {
> +DefinitionBlock ("Ssdt.aml", "SSDT", 2, "REDHAT", "OVMF ", 1) {
> }
Wouldn't it be better to simply remove this file?
next prev parent reply other threads:[~2021-12-21 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 15:06 [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field Rebecca Cran
2021-12-21 16:31 ` Ard Biesheuvel [this message]
2021-12-21 16:57 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXG9Np4P+ky=2pVT2iiGfG2osRMwB2Rg07O0Rv8XiZXUNw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox