From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9A3CCAC17A1 for ; Tue, 19 Dec 2023 13:59:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TRuC2/yafiLfyz8OrHQ9tPK4P3XchxIgJxTzq6twG24=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702994360; v=1; b=THnVUJNvIAmUzAnI25pd7xZJQJkauJMLasm5h9e2fmVqqWbYT+AB2zzA7bQufGkAZp8gJ9N3 OZH7HMXwg67OlCDtr4jWzoMgODFZZAZLrTzPqhxdKkoDrjbYA47ReAInxhKBQNK4Oa9Lznwg8Im FYkdVrJvJOjdqU8m6RtOs3sM= X-Received: by 127.0.0.2 with SMTP id 8OWcYY7687511xudF1vY6HEl; Tue, 19 Dec 2023 05:59:20 -0800 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.14159.1702994358925730527 for ; Tue, 19 Dec 2023 05:59:19 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D5D55CE180E for ; Tue, 19 Dec 2023 13:59:15 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F4AC433D9 for ; Tue, 19 Dec 2023 13:59:14 +0000 (UTC) X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2cc6b5a8364so28197861fa.2 for ; Tue, 19 Dec 2023 05:59:14 -0800 (PST) X-Gm-Message-State: CW0kZzY6Tqscq4RBSl3WRcnwx7686176AA= X-Google-Smtp-Source: AGHT+IHO2VhufED6Dsa4xhJmRfCFtOcSJwo8rs/D4M63Qunq2+7zj53oQTmPO58EwajOpa6dh6ujySHjJHZ6mW2QoIk= X-Received: by 2002:a2e:be0b:0:b0:2cc:88ce:84c1 with SMTP id z11-20020a2ebe0b000000b002cc88ce84c1mr116739ljq.16.1702994352604; Tue, 19 Dec 2023 05:59:12 -0800 (PST) MIME-Version: 1.0 References: <20231031173700.647004-1-ngompa@fedoraproject.org> <58ec87dc-ce03-6ad8-681a-d815bc5c39f9@arm.com> <00e301da327b$3b935b10$b2ba1130$@byosoft.com.cn> In-Reply-To: <00e301da327b$3b935b10$b2ba1130$@byosoft.com.cn> From: "Ard Biesheuvel" Date: Tue, 19 Dec 2023 14:59:01 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: quic_llindhol@quicinc.com, ngompa13@gmail.com, Michael Kinney , Laszlo Ersek , Jeremy Linton , Pete Batard , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Gerd Hoffmann , Samer El-Haj-Mahmoud Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=THnVUJNv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 19 Dec 2023 at 14:00, gaoliming via groups.io wrote: > > Yes. The latest spec has clarified this behavior. So, this change is OK. = Reviewed-by: Liming Gao > Merged as #5165 Thanks all > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Leif Lindholm > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B412=E6=9C=8819=E6=97= =A5 19:51 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; ardb@kernel.org > > =E6=8A=84=E9=80=81: ngompa13@gmail.com; Liming Gao (Byosoft address) > > ; Michael Kinney = ; > > Laszlo Ersek ; Jeremy Linton = ; > > Pete Batard ; Daniel P . Berrang=C3=A9 ; > > Gerd Hoffmann ; Samer El-Haj-Mahmoud > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootMa= nagerLib: > > Signal ReadyToBoot on platform recovery > > > > On Mon, Dec 18, 2023 at 22:55:21 +0100, Ard Biesheuvel wrote: > > > Hello all, > > > > > > Same question again. Could we please make some progress on this? > > > > > > Full thread here: > > > > > https://openfw.io/edk2-devel/20231031173700.647004-1-ngompa@fedorap > > roject.org/ > > > > > > If nobody objects, I will assume that the change is acceptable and > > > merge it by the end of the week. > > > > I'm OK with this. > > > > The last comment from Liming in > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2831 > > was that the fix could be merged after "the next UEFI is published", > > which it was - in August 2022. > > > > Reviewed-by: Leif Lindholm > > > > Regards, > > > > Leif > > > > > > > Thanks, > > > Ard. > > > > > > > > > > > > On Tue, 12 Dec 2023 at 09:11, Ard Biesheuvel wrote: > > > > > > > > (cc Mike, Leif) > > > > > > > > On Thu, 7 Dec 2023 at 08:40, Ard Biesheuvel wrote= : > > > > > > > > > > (cc Liming) > > > > > > > > > > On Thu, 7 Dec 2023 at 05:48, Neal Gompa > > wrote: > > > > > > > > > > > > On Fri, Nov 24, 2023 at 6:36=E2=80=AFPM Neal Gompa > > wrote: > > > > > > > > > > > > > > On Thu, Nov 2, 2023 at 6:35=E2=80=AFAM Laszlo Ersek > > wrote: > > > > > > > > > > > > > > > > On 10/31/23 23:27, Jeremy Linton wrote: > > > > > > > > > On 10/31/23 12:37, Neal Gompa via groups.io wrote: > > > > > > > > >> From: Neal Gompa > > > > > > > > >> > > > > > > > > >> Currently, the ReadyToBoot event is only signaled when a= formal > > Boot > > > > > > > > >> Manager option is executed (in BmBoot.c -> > > EfiBootManagerBoot ()). > > > > > > > > >> > > > > > > > > >> However, the introduction of Platform Recovery in UEFI 2= .5 > > makes it > > > > > > > > >> necessary to signal ReadyToBoot when a Platform Recovery > > boot loader > > > > > > > > >> runs because otherwise it may lead to the execution of a= boot > > loader > > > > > > > > >> that has similar requirements to a regular one that is n= ot > > launched > > > > > > > > >> as a Boot Manager option. > > > > > > > > >> > > > > > > > > >> This is especially critical to ensuring that the graphic= al console > > > > > > > > >> is actually usable during platform recovery, as some pla= tforms > > do > > > > > > > > >> rely on the ConsolePrefDxe driver, which only performs c= onsole > > > > > > > > >> initialization after ReadyToBoot is triggered. > > > > > > > > >> > > > > > > > > >> This patch fixes that behavior by calling > > EfiSignalEventReadyToBoot () > > > > > > > > >> in EfiBootManagerProcessLoadOption () when invoking plat= form > > recovery, > > > > > > > > >> which is the function that sets up the platform recovery= boot > > process. > > > > > > > > >> > > > > > > > > >> The expected behavior has been clarified in the UEFI 2.1= 0 > > specification > > > > > > > > >> to explicitly indicate this behavior is required for cor= rect > > operation. > > > > > > > > >> > > > > > > > > >> This is a rebased version of the patch originally writte= n by Pete > > Batard. > > > > > > > > > > > > > > > > > > Took me a bit to swap in that whole conversation again, a= nd > > recheck the > > > > > > > > > spec's and code paths, but this all looks fine to me and = should > > allow > > > > > > > > > the PFTF build to drop the similar patch from Pete that h= as been > > carried > > > > > > > > > downstream for the past couple years. > > > > > > > > > > > > > > > > > > As for testing the previous patch has been in the field f= or a couple > > > > > > > > > years now and i'm not aware of it causing any issues. The > > additional > > > > > > > > > restriction of limiting it to platform recovery logically= makes > > sense, > > > > > > > > > and as far as I can see shouldn't cause any problems. > > > > > > > > > > > > > > > > > > So, > > > > > > > > > > > > > > > > > > Reviewed-by: Jeremy Linton > > > > > > > > > > > > > > > > > > > > > > > > > > > As a PS: I also went to check the ready to boot behavior = for > > OsRecovery > > > > > > > > > and realized that apparently none of that support was eve= r > > merged? > > > > > > > > > > > > > > > > What else is there, outside of this patch, in need of upstr= eaming? > > > > > > > > > > > > > > > > > That seems a bit of an oversight since its been in the sp= ec for a > > few years now. > > > > > > > > > > > > > > > > "ready-to-boot for OsRecovery" is new in UEFI 2.10 (accordi= ng to > > the > > > > > > > > commit message), which is quite recent ("Aug 29, 2022"). > > > > > > > > > > > > > > > > I couldn't find the Mantis ticket in the Revision History (= for 2.10) > > though. > > > > > > > > > > > > > > > > > > > > > > Is there anything else holding up committing this patch? Jere= my and > > > > > > > you reviewed it earlier in the month... > > > > > > > > > > > > > > > > > > > Friendly ping again? It's been a month now... > > > > > > > > > > > > > > > > Apologies for the delay - Liming, can we progress with this? > > > > > > > > Can we please make some progress with this? This has been in limbo = for > > > > far too long. > > > > > > > > Thanks, > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112729): https://edk2.groups.io/g/devel/message/112729 Mute This Topic: https://groups.io/mt/103262405/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-