From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.6560.1663933653597474988 for ; Fri, 23 Sep 2022 04:47:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PAuLHU4M; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ACCBC6126E for ; Fri, 23 Sep 2022 11:47:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F9E0C433C1 for ; Fri, 23 Sep 2022 11:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663933652; bh=hUYYphlNrVjdkMtLRFGPSHYOAjAOsuXsKZfnqIBZV2A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PAuLHU4MR7J3MZ4uq+xRwpJH53tqF4eWq2rPU575Vrb0WpuqAw5qDWrz1oaaTPIyx IOBHCAW5MydZ6P7q1NubWlorhZCz3YM0T9LQ7j6jYT6lCdi2/JoqV6ahWkJDi5Iqj2 TrufhsLlfOoNAPvyTqj2EfKWjDIAOT+i483viuJAbSOpNhPmCPhNUilpK28w4hrf/E HM9xxvbTZIB+15rg9IYkEskC/qRIvR05YeC9Ee2zrCyvD+LNyMgvlSscWhvKBRtpmI 4cDMiry77vIt7fSjq/QnuvIqgnaR42VVBL1lYCM8SF6QKTdyeDjhd+NiiUjJRQpbtj Ytk8gSGYtvMgA== Received: by mail-lj1-f176.google.com with SMTP id h3so14387112lja.1 for ; Fri, 23 Sep 2022 04:47:32 -0700 (PDT) X-Gm-Message-State: ACrzQf0XkIwvjyvCQ6w3YdnNT1krnC1soGWINWYdFYX2J7iIcsq3GsHR EYzfoXbW9qz8xsQhLKz8ghGWLF9XTAbiuZG2bl8= X-Google-Smtp-Source: AMsMyM43bkQBRWHE9DUHcGzDy58oiTLMed0pgEPpOMz8Jtq/BYkF27cN/zwd67jP54C+90J9EmmCmsjgm69LZHFYnNw= X-Received: by 2002:a05:651c:1a26:b0:26c:4c0d:b10a with SMTP id by38-20020a05651c1a2600b0026c4c0db10amr2562584ljb.415.1663933650116; Fri, 23 Sep 2022 04:47:30 -0700 (PDT) MIME-Version: 1.0 References: <20220907023649.312-1-mikuback@linux.microsoft.com> <9e215e11-31cc-9b4d-2290-6cfd26f816a2@linux.microsoft.com> <907355f3-3745-a9b7-8b43-dabc2d14cf7d@linux.microsoft.com> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 23 Sep 2022 13:47:18 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI To: Michael Kubacki Cc: "Kinney, Michael D" , "devel@edk2.groups.io" , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer Content-Type: text/plain; charset="UTF-8" On Fri, 23 Sept 2022 at 03:09, Michael Kubacki wrote: > > What are the next steps? > As long as we are using the most lenient setting, I'm ok with this Acked-by: Ard Biesheuvel > On 9/15/2022 5:54 PM, Kinney, Michael D wrote: > > Hi Ard, > > > > If there is content you do not think needs to follow the min quality criteria, perhaps it can be moved out of edk2 repo? Maybe to edk2-staging or edk2-archive? > > > > Thanks, > > > > Mike > > > >> -----Original Message----- > >> From: Ard Biesheuvel > >> Sent: Thursday, September 15, 2022 2:03 PM > >> To: Kinney, Michael D > >> Cc: Michael Kubacki ; devel@edk2.groups.io; Leif Lindholm ; Ard > >> Biesheuvel ; Abner Chang ; Daniel Schaefer > >> Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI > >> > >> On Thu, 15 Sept 2022 at 22:52, Kinney, Michael D > >> wrote: > >>> > >>> Ard, > >>> > >>> Why would you want to do that? The whole point of CI is to establish a minimum quality level for all code in the project. > >>> > >>> They can be disabled with updates to the YAML file. Checks can be disabled completely and may of the checks support > >> exception lists. > >>> > >> > >> If the only way to prevent this from happening is to turn it off again > >> in the YAML file, I'd prefer not to turn it on to begin with. > >> > >> I agree that code quality is important, but IMO the checks we have at > >> the moment are way too strict, and 90% of the time I spend on > >> reviewing and merging patches is on crustify and patchcheck errors. > >> This is simply not worth my time.