From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.10464.1683701404087511638 for ; Tue, 09 May 2023 23:50:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XoWc6Pq6; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84C4663A4D for ; Wed, 10 May 2023 06:50:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAC66C433A1 for ; Wed, 10 May 2023 06:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683701402; bh=4DbI5kIxBRkc3oXcwGZoAe/m8Zp0B4Mb7peObZ2szy8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XoWc6Pq6mGPcbM8eP3h/fqyVjSZr8owEG/1DEyCY0CaW7tmqAiuka+8EWT3RMM6b4 0gqFGFfxFM4XQzHeVCY3DuuVhzUCSERm+Lob+RKAKFmIb6INc9cS/kYv767jPoKOdr U8QOFcCRlGhaF0Uy2+/IfAvz8LNUFALZaoL95Wp9ZAFcxjczwCCHegkQCZkgf+dNLA 5AqJzyF2AWzrB9IWJ8IYfqyd7UxLTlj4i2OP3tiGel4bpDTjOn7Nf9gkIoz58B4Re5 +pANi6gxT6NzOEgpZRwtBxIVUIyuP/wS0GhuEOI8r7Rior4CskQ+Hw3q/gWExyZ/qp um0HbAqMVTyFg== Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4f00c33c3d6so7724180e87.2 for ; Tue, 09 May 2023 23:50:02 -0700 (PDT) X-Gm-Message-State: AC+VfDyIUIK/jPSLiQELkKXTmyl26tE4Owhus1n16E4i1mdcVkH9irzx OJkduqQqjCDXWFAzFTTeF7yHTBSUW9ApljWAha8= X-Google-Smtp-Source: ACHHUZ5B520FykU6j8TLqkPJp7RCQot97odI9jrnHX2jE3RxQk2UPX/fYkOq87M5yNxQVHoGoQ6obauIqhS+HSP3Mu8= X-Received: by 2002:a19:a40f:0:b0:4d1:3d1d:4914 with SMTP id q15-20020a19a40f000000b004d13d1d4914mr1456365lfc.33.1683701400785; Tue, 09 May 2023 23:50:00 -0700 (PDT) MIME-Version: 1.0 References: <20230509163212.291333-1-pedro.falcato@gmail.com> In-Reply-To: <20230509163212.291333-1-pedro.falcato@gmail.com> From: "Ard Biesheuvel" Date: Wed, 10 May 2023 08:49:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one To: Pedro Falcato Cc: devel@edk2.groups.io, Laszlo Ersek , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , =?UTF-8?Q?Corvin_K=C3=B6hne?= , Sebastien Boeuf , Anthony Perard , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 9 May 2023 at 18:32, Pedro Falcato wrote: > > This patch-set replaces the OVMF specific SataControllerDxe with the MdeM= odulePkg/Bus/Pci one. > They were both forked from the same code, and are code-and-functionality = similar. As such, there > seems to be no need for duplication here. > > The first four pages both replay OvmfPkg/SataControllerDxe commits and fi= x up a couple of details. > The rest of the patches (minus the last) replace OvmfPkg/SataControllerDx= e with the MdeModulePkg variant. > The last patch, finally, removes the thing. > > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). > More testing from other, alternative platforms is desired, although break= age seems unlikely. > > This patchset (or at least, the last patch) depends on the edk2-platforms= patch series to get merged. > > (+CC Laszlo as the author of the original SataControllerDxe patches) > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc :Jordan Justen > Cc: Gerd Hoffmann > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Min Xu > Cc: Tom Lendacky > Cc: Michael Roth > Cc: Rebecca Cran > Cc: Peter Grehan > Cc: Corvin K=C3=B6hne > Cc: Sebastien Boeuf > Cc: Anthony Perard > Cc: Julien Grall > Cc: Laszlo Ersek > > Changes: > v2: > - Address Laszlo's feedback wrt commit to port into MdeModulePkg > - Address Laszlo's feedback wrt how to split the removal of the driver = and the patches for each sub-platform maintainer > - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Private= !=3D NULL) > - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12 (si= nce they are remotely QEMU related) > > Pedro Falcato (12): > MdeModulePkg/SataControllerDxe: Clean up error handling in Start() > MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO > level > MdeModulePkg/SataControllerDxe: Remove useless null check > MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private !=3D NULL) > OvmfPkg: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe > OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe > OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe > OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe > OvmfPkg: Remove SataControllerDxe > Acked-by: Ard Biesheuvel