From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.1132.1677610440224741152 for ; Tue, 28 Feb 2023 10:54:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jwv+BO7O; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C631DB80EB4 for ; Tue, 28 Feb 2023 18:53:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 660D6C433A1 for ; Tue, 28 Feb 2023 18:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677610436; bh=q3XMWOzCDDsUS4bOPVcc47ZLst6tTOwOiFQgIaxCksw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jwv+BO7ONXiDxFyoJj0cr3Q8blSBMHzTMfGwwHbjKHz6Uthczrien50ScaDEHsFF+ 6+dNsgpWnvxrdy/orJC4mDSpyv4T6t+Ik6l803LkYd0+B95LuPje/i3Py0+7kvt55L UQawzRLUQRTvujcHIJyxPtVV8gVgpkeEAjp6qJKhPmnBMR1JqAk1jA7RgsS5L52pQc 2/OlDPz20cKo45bmUEywGXkxSrW3NLBkBT633ZIXj+gNeJXtwuw4VkxyLZ9I0ATNAQ wGgD2jJznOjsd8jzfw65KCjXE6p5BORUx2gT8vrP4rW9MP6K3clFrqYhMdlc3OWNt5 ZDFZorQRCMDWw== Received: by mail-lf1-f41.google.com with SMTP id i9so14524442lfc.6 for ; Tue, 28 Feb 2023 10:53:56 -0800 (PST) X-Gm-Message-State: AO0yUKXerUF/j3fVKhTEU5b1CnH+RuwS/RMD2bGJlwImiEpS1ONPgmJ9 hMJZFqmu/WgEPTDixVRmQEcFetfdhPvRyToyII8= X-Google-Smtp-Source: AK7set8GVCHC/Jva8KIDKEUJd25v15DVl3LJ2kzqRSxAsJPdFyeM17IacpJZ4WCAf8jUdE5hRuBh6rxt8zd1okW7dRQ= X-Received: by 2002:ac2:4c2a:0:b0:4dc:807a:d148 with SMTP id u10-20020ac24c2a000000b004dc807ad148mr1038465lfq.7.1677610434410; Tue, 28 Feb 2023 10:53:54 -0800 (PST) MIME-Version: 1.0 References: <20230227034702.82215-1-rebecca@bsdio.com> <4c6db5b3-57ad-e3e3-9074-98741b7fd4fb@bsdio.com> In-Reply-To: <4c6db5b3-57ad-e3e3-9074-98741b7fd4fb@bsdio.com> From: "Ard Biesheuvel" Date: Tue, 28 Feb 2023 19:53:43 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details To: Rebecca Cran Cc: "Kinney, Michael D" , "devel@edk2.groups.io" , Andrew Fish , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Tue, 28 Feb 2023 at 19:20, Rebecca Cran wrote: > > Before I sent out an official v2 patch, does the following look good? > Looks fine to me, thanks. > > diff --git a/.editorconfig b/.editorconfig > new file mode 100644 > index 000000000000..587d5bbaa884 > --- /dev/null > +++ b/.editorconfig > @@ -0,0 +1,31 @@ > +# EditorConfig file: https://EditorConfig.org > + > +root = true > + > +[*] > +charset = latin1 > +end_of_line = crlf > +indent_style = space > +indent_size = 2 > +insert_final_newline = true > +trim_trailing_whitespace = true > + > +[*.py] > +charset = utf-8 > +indent_style = space > +indent_size = 4 > + > +[*.sh] > +end_of_line = lf > + > +[.gitattributes] > +end_of_line = lf > + > +[.mailmap] > +charset = utf-8 > + > +[Maintainers.txt] > +charset = utf-8 > + > +[Makefile,GNUmakefile] > +indent_style = tab > > > -- > Rebecca Cran > > > On 2/27/23 11:23 AM, Kinney, Michael D wrote: > > .gitmodules also must also use tabs. > > > >> -----Original Message----- > >> From: Kinney, Michael D > >> Sent: Monday, February 27, 2023 10:22 AM > >> To: Ard Biesheuvel ; devel@edk2.groups.io; rebecca@bsdio.com > >> Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D > >> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >> > >> .gitmodules must be lf. Not sure about other git config files. > >> > >> Mike > >> > >>> -----Original Message----- > >>> From: Ard Biesheuvel > >>> Sent: Monday, February 27, 2023 10:18 AM > >>> To: devel@edk2.groups.io; rebecca@bsdio.com > >>> Cc: Kinney, Michael D ; Andrew Fish ; Leif Lindholm > >>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>> > >>> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran wrote: > >>>> Is it just .sh files that need lf endings, or are there others? > >>>> > >>> I think this only applies to .sh files. > >>> > >>>> > >>>> On 2/27/23 9:14 AM, Michael D Kinney wrote: > >>>>> There are a few file types that must be lf instead of crlf. Can those be added as well? > >>>>> > >>>>> Mike > >>>>> > >>>>>> -----Original Message----- > >>>>>> From: devel@edk2.groups.io On Behalf Of Rebecca Cran > >>>>>> Sent: Monday, February 27, 2023 5:03 AM > >>>>>> To: Ard Biesheuvel ; devel@edk2.groups.io > >>>>>> Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D > >>> > >>>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>>>>> > >>>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > >>>>>> > >>>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran wrote: > >>>>>>>> Add a .editorconfig file which editors can use for basic formatting > >>>>>>>> details of files, such as tabs/spaces, line endings etc. > >>>>>>>> > >>>>>>>> Signed-off-by: Rebecca Cran > >>>>>>> Thank you very much for this - this is very useful. > >>>>>>> > >>>>>>> Acked-by: Ard Biesheuvel > >>>>>>> > >>>>>>> Could we add .dsc/.inf/.dec/etc files as well? > >>>>>> I'll move the c/c++ indentation up to the [*] section so it applies to > >>>>>> .dsc/.inf/etc too. > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Rebecca Cran > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>> > >>>> > >>>> > >>>>