public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	 Leif Lindholm <quic_llindhol@quicinc.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	 Gerd Hoffmann <kraxel@redhat.com>,
	Erdem Aktas <erdemaktas@google.com>,
	 James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	 Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V1 0/2] Check PcdConfidentialComputingGuestAttr in AcpiPlatformDxe
Date: Thu, 22 Dec 2022 14:20:09 +0100	[thread overview]
Message-ID: <CAMj1kXGCBaGnG+_PX9mi0O5ti9s1LZaZyLh+ZD9DMw+_ye4EXw@mail.gmail.com> (raw)
In-Reply-To: <20221222131156.411-1-min.m.xu@intel.com>

On Thu, 22 Dec 2022 at 14:12, Min Xu <min.m.xu@intel.com> wrote:
>
> PcdConfidentialComputingGuestAttr can be used to check the cc guest
> type, including td-guest or sev-guest. CcProbe() can do the same
> thing but CcProbeLib should be included in the dsc which uses
> AcpiPlatformDxe. The difference between PcdConfidentialComputingGuestAttr
> and CcProbe() is that PcdConfidentialComputingGuestAttr cannot be used
> in multi-processor scenario but CcProbe() can. But there is no such
> issue in AcpiPlatformDxe.
>
> So we use PcdConfidentialComputingGuestAttr instead of CcProbeLib so that
> it is simpler.
>
> After CcProbe is removed from AcpiPlatformDxe, it is removed
> from ArmVirtQemu.dsc as well.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
>
> Min M Xu (2):
>   OvmfPkg/AcpiPlatformDxe: Check PcdConfidentialComputingGuestAttr
>   ArmVirtPkg: Remove CcProbeLib from ArmVirtQemu.dsc
>

Thanks for the quick fix!

PR queued as #3821

      parent reply	other threads:[~2022-12-22 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 13:11 [PATCH V1 0/2] Check PcdConfidentialComputingGuestAttr in AcpiPlatformDxe Min Xu
2022-12-22 13:11 ` [PATCH V1 1/2] OvmfPkg/AcpiPlatformDxe: Check PcdConfidentialComputingGuestAttr Min Xu
2022-12-22 13:11 ` [PATCH V1 2/2] ArmVirtPkg: Remove CcProbeLib from ArmVirtQemu.dsc Min Xu
2022-12-22 13:20 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXGCBaGnG+_PX9mi0O5ti9s1LZaZyLh+ZD9DMw+_ye4EXw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox