From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.45067.1671715226251222145 for ; Thu, 22 Dec 2022 05:20:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QdWb9J2W; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ABA2AB81AFD for ; Thu, 22 Dec 2022 13:20:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D24BCC4339B for ; Thu, 22 Dec 2022 13:20:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671715222; bh=ZUDKHY+jcatiK3ZdoQTNMtp7FlVsqDSTGHS7/b+vYpY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QdWb9J2WtjH5dkLlVx2HleV9Z7TQNwTvTtSbCE9hQ6I3qMlzI4LYbxLekYKSQWFGI JkfvUFqey7xCJDvd3VWvttuSH5Ym6WqMiG8SBpHj4obRysPSjzwrDLpJh6NPazURld dZk0pk2e507r9GO4PLaj+nu9bxcovvYaSygQS7PCPgW+eJHw3bs7qG2XPB8CKfJXB8 tZ9HPO4VPcw7vUlVNb96i1yzjVp09S0h08zIMnEwhDDyDG0lJLZjf9clSCecageyNB CyQek6qy47nJ6Qymr/uNAeLaLGAqk/EkBIejf1TZZO+s/efxjrdLHAgo2gm/x8pWHC VjkRsm8EK6IYQ== Received: by mail-lj1-f176.google.com with SMTP id f16so1857386ljc.8 for ; Thu, 22 Dec 2022 05:20:22 -0800 (PST) X-Gm-Message-State: AFqh2kpkcR0tSbySdrwqiAmy6XLTA151qCFtxnsVe3bf8ekdbrTnYozn bGSfbBQiLig46fK7hTIvgJXNBbq4AzgZ3xYYV/E= X-Google-Smtp-Source: AMrXdXtRW+EsuGNZbywfzMBagFhWFarM0YMOfet0LVY/7b93oZHTmvpJFngH+dXLLfr51sx5II2LhA4uWR/4TUbhcgE= X-Received: by 2002:a2e:2413:0:b0:27b:54ad:6c59 with SMTP id k19-20020a2e2413000000b0027b54ad6c59mr463944ljk.352.1671715220860; Thu, 22 Dec 2022 05:20:20 -0800 (PST) MIME-Version: 1.0 References: <20221222131156.411-1-min.m.xu@intel.com> In-Reply-To: <20221222131156.411-1-min.m.xu@intel.com> From: "Ard Biesheuvel" Date: Thu, 22 Dec 2022 14:20:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V1 0/2] Check PcdConfidentialComputingGuestAttr in AcpiPlatformDxe To: Min Xu Cc: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Content-Type: text/plain; charset="UTF-8" On Thu, 22 Dec 2022 at 14:12, Min Xu wrote: > > PcdConfidentialComputingGuestAttr can be used to check the cc guest > type, including td-guest or sev-guest. CcProbe() can do the same > thing but CcProbeLib should be included in the dsc which uses > AcpiPlatformDxe. The difference between PcdConfidentialComputingGuestAttr > and CcProbe() is that PcdConfidentialComputingGuestAttr cannot be used > in multi-processor scenario but CcProbe() can. But there is no such > issue in AcpiPlatformDxe. > > So we use PcdConfidentialComputingGuestAttr instead of CcProbeLib so that > it is simpler. > > After CcProbe is removed from AcpiPlatformDxe, it is removed > from ArmVirtQemu.dsc as well. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Signed-off-by: Min Xu > > Min M Xu (2): > OvmfPkg/AcpiPlatformDxe: Check PcdConfidentialComputingGuestAttr > ArmVirtPkg: Remove CcProbeLib from ArmVirtQemu.dsc > Thanks for the quick fix! PR queued as #3821