From: "Ard Biesheuvel" <ardb@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>,
devel@edk2.groups.io, philmd@redhat.com,
ardb+tianocore@kernel.org, jiewen.yao@intel.com,
jordan.l.justen@intel.com
Subject: Re: [PATCH] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAlignment.
Date: Wed, 12 Apr 2023 13:13:40 +0200 [thread overview]
Message-ID: <CAMj1kXGCBd6oEU051=68JqLrwfuAeMU6op60bcm3g+amp_MpFA@mail.gmail.com> (raw)
In-Reply-To: <qalmafderpsso373fwukddzjxeknghamkhb4ikvq2ei6lw72sg@65uhkks33xgs>
On Fri, 24 Mar 2023 at 13:30, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Fri, Mar 24, 2023 at 01:42:17AM +0000, Jeff Brasen wrote:
> > Nothing to do here for virtio 1.0 devices
> >
> > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > ---
> > .../Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> > index 8bdf1e1fc3..de2c5fa2a6 100644
> > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> > @@ -144,7 +144,9 @@ VirtioMmioSetQueueAlignment (
> >
> > Device = VIRTIO_MMIO_DEVICE_FROM_VIRTIO_DEVICE (This);
> >
> > - VIRTIO_CFG_WRITE (Device, VIRTIO_MMIO_OFFSET_QUEUE_ALIGN, Alignment);
> > + if (Device->Version == VIRTIO_MMIO_DEVICE_VERSION_0_95) {
> > + VIRTIO_CFG_WRITE (Device, VIRTIO_MMIO_OFFSET_QUEUE_ALIGN, Alignment);
> > + }
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
Queuing this up now - apologies for the delay.
prev parent reply other threads:[~2023-04-12 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 1:42 [PATCH] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAlignment Jeff Brasen
2023-03-24 12:30 ` Gerd Hoffmann
2023-04-12 11:13 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGCBd6oEU051=68JqLrwfuAeMU6op60bcm3g+amp_MpFA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox