Re: [edk2-devel] [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common

["Ard Biesheuvel" <ardb@kernel.org>]

On Tue, 1 Feb 2022 at 17:58, Rebecca Cran <quic_rcran@quicinc.com> wrote:
>
> Sorry, I forgot to add a cover letter.
>
> I noticed some breakages in Arm platforms caused by additions of
> VariablePolicyHelperLib: the 3 patches fix them by adding it to
> LibraryClasses.common.
>
>

No worries - I'll pick these up momentarily.



>
>
> On 2/1/22 09:56, Rebecca Cran wrote:
> > The VariablePolicyHelperLib is now used by a number of driver types, so
> > instead of duplicating it, move it into the LibraryClasses.common section.
> >
> > Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> > ---
> >   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > index af207391209c..41c1cadc3425 100644
> > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > @@ -125,6 +125,7 @@ DEFINE X64EMU_ENABLE  = FALSE
> >     OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> >     RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
> >     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> > +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> >     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> >
> >     UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > @@ -209,7 +210,6 @@ DEFINE X64EMU_ENABLE  = FALSE
> >     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> >     MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> >     NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> > -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> >
> >   [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> >     HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> > @@ -219,7 +219,6 @@ DEFINE X64EMU_ENABLE  = FALSE
> >     DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> >   !endif
> >     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> > -  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> >
> >   [LibraryClasses.common.UEFI_APPLICATION]
> >     PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
>
>
> 
>
>