From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web09.51406.1643734790482491875 for ; Tue, 01 Feb 2022 08:59:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zwrgnw9x; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 26A21B822B1 for ; Tue, 1 Feb 2022 16:59:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0EF5C340F0 for ; Tue, 1 Feb 2022 16:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643734786; bh=Kpbc/LvVcX0Gm6m7iIV6ouvQJRVjlc5n9mIiSKB7dhY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Zwrgnw9xKD7uPDooUs8nLh5E4T4iFFRgEnZCbaHxxk08oLbo7ao95wnHC2a413ORv WbYLsk8mPWinDftQw/cNH5nEwYyBuRleZmzpxsHBgqmXgyyeBybZrt6rNL5Pu9dXq1 /QjzesPtsMzuPB63wLDwxZJACd4d14agU0N0FyNSRJzf1duQ/nPuxzBO7OrLMLc7dJ BUrDw5TCplXXB93rGO/gN+RQFHvwKXabO9bIpE9cVBxhcX5WrmU9HrLXgZDQUoB+1g 53xrZD3xraRavhTCxjI3hTFvy4aJnLrKDXJTd5siBOUF54lgkUSqemvEEjsFXdKHpm CuCaLlsxu3KlQ== Received: by mail-wr1-f49.google.com with SMTP id h21so33277690wrb.8 for ; Tue, 01 Feb 2022 08:59:46 -0800 (PST) X-Gm-Message-State: AOAM5329XbYOesbNBoenJ5ZjmUudh4mIfWkedvbIXQ3FongXzK2OUmvc DBiRM5gCc4++VOwESvLHG5ppQ85Y9RzB7xpgA+k= X-Google-Smtp-Source: ABdhPJzTJPw8OE29JawY1D87y5GC4ktcO24Tw2azPkIJon+/f5/QJuHgaRU0meHJpLpVQTQ8WWZ+zh/7+UTVGlNwvSo= X-Received: by 2002:a05:6000:1107:: with SMTP id z7mr22113780wrw.189.1643734785178; Tue, 01 Feb 2022 08:59:45 -0800 (PST) MIME-Version: 1.0 References: <20220201165627.25216-1-quic_rcran@quicinc.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 1 Feb 2022 17:59:33 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common To: edk2-devel-groups-io , Rebecca Cran Cc: Ard Biesheuvel , Leif Lindholm , Marcin Wojtas , Masami Hiramatsu Content-Type: text/plain; charset="UTF-8" On Tue, 1 Feb 2022 at 17:58, Rebecca Cran wrote: > > Sorry, I forgot to add a cover letter. > > I noticed some breakages in Arm platforms caused by additions of > VariablePolicyHelperLib: the 3 patches fix them by adding it to > LibraryClasses.common. > > No worries - I'll pick these up momentarily. > > > On 2/1/22 09:56, Rebecca Cran wrote: > > The VariablePolicyHelperLib is now used by a number of driver types, so > > instead of duplicating it, move it into the LibraryClasses.common section. > > > > Signed-off-by: Rebecca Cran > > --- > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > index af207391209c..41c1cadc3425 100644 > > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > @@ -125,6 +125,7 @@ DEFINE X64EMU_ENABLE = FALSE > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf > > TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf > > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > > > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > @@ -209,7 +210,6 @@ DEFINE X64EMU_ENABLE = FALSE > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > > - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > @@ -219,7 +219,6 @@ DEFINE X64EMU_ENABLE = FALSE > > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > > !endif > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > > > [LibraryClasses.common.UEFI_APPLICATION] > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > > > >