From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 57286AC0EFE for ; Wed, 8 May 2024 09:09:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ae1Z9X9ngRi9/BTn/Pp4Q8kx52XpE74/8gPa1tycA58=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1715159347; v=1; b=Oq5p5j05mTTcVC2MTP4pk93R8+31CrnWd1KnnwrXXokTwY3bhd1bksbUphD9rlDBaqqRozOi 0s8qVWLSFteGmmbKRN5qBLDQW+DWVt0V/3OW4kuedHrMxLDXS8c2LqpoHjTDMJuqfBSfuOl+dIA QStho4Ka2rg+5IVTCzKC/wB/68MAB9Oaf6RuuAK8RI05S9felzo6iPOlIuKFzSIuvJsQx1gnPMP nKjLCNJ0lhejt47cg4Y853H9T8x1XJVOM7vQdOChvRxyqVw/45ssoyViad5TJdp6gAKiAhW4Qbl EOtwBjPqPehjoWp4XQiGA45MMTnEcR39Wv85yc8uyV4CQ== X-Received: by 127.0.0.2 with SMTP id 7NpzYY7687511xsYeWAv6GhY; Wed, 08 May 2024 02:09:07 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web10.7661.1715159346801253812 for ; Wed, 08 May 2024 02:09:07 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A57B8CE14E7 for ; Wed, 8 May 2024 09:09:04 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAB59C4AF67 for ; Wed, 8 May 2024 09:09:03 +0000 (UTC) X-Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-51ffff16400so5943299e87.2 for ; Wed, 08 May 2024 02:09:03 -0700 (PDT) X-Gm-Message-State: idkYx0KpGrZinUBRP088rpoXx7686176AA= X-Google-Smtp-Source: AGHT+IEY8nTbKelLuRgdlzkCZgzHSRHrXtgN9nW9yqRHrlkdl3NAlB8/d/uQnpV4joO1oipI4XG3FAIyqSq+T95/h+8= X-Received: by 2002:a05:6512:34da:b0:51d:9291:6945 with SMTP id 2adb3069b0e04-5217cd495fbmr1581985e87.44.1715159342048; Wed, 08 May 2024 02:09:02 -0700 (PDT) MIME-Version: 1.0 References: <20240508085148.1725-1-pete@akeo.ie> <20240508085148.1725-2-pete@akeo.ie> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 8 May 2024 11:08:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio To: Pete Batard Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 08 May 2024 02:09:07 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Oq5p5j05; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 8 May 2024 at 11:07, Ard Biesheuvel wrote: > > On Wed, 8 May 2024 at 10:52, Pete Batard wrote: > > > > Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression > > resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer' > > when compling MdePkg for AARCH64 with Visual Studio. > > Fix this by adding the relevant EXTERN reference. > > > > Signed-off-by: Pete Batard > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Reviewed-by: Ard Biesheuvel > > Note that the same issue has been raised two months ago, and a similar > fix proposed > > https://openfw.io/edk2-devel/20240320025130.599086-1-adam.liu@tw.synaptics.com/ > > so IMHO this qualifies for inclusion in the stable tag. > BTW the existence of this issue appears to imply that the VS RELEASE build does not #define MDEPKG_NDEBUG. Is that an oversight? > > > --- > > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > index 6ec8f35f2c9f..fa161e25f517 100644 > > --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > > @@ -7,6 +7,7 @@ > > > > EXPORT SetJump > > EXPORT InternalLongJump > > + EXTERN InternalAssertJumpBuffer > > AREA BaseLib_LowLevel, CODE, READONLY > > > > #define GPR_LAYOUT \ > > -- > > 2.45.0.windows.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118668): https://edk2.groups.io/g/devel/message/118668 Mute This Topic: https://groups.io/mt/105977470/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-