From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.7862.1630070216919862057 for ; Fri, 27 Aug 2021 06:16:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cIG1dVXf; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 78F1260F91 for ; Fri, 27 Aug 2021 13:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630070215; bh=EW8knsV19Qe6FM+deVsHbPVIdVFl1JJZO2eBdBFZDko=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cIG1dVXfO+xF3dnQeKn/6ydw/ufjJMu0zf+jLVSQ0CAuoXgfaeOUXyJSYlQVOMoBa MgrsyYuPR7mP/joXhA8LNuFkpm3HTtyKWAvPc0tFe8dPHp/IaWUYQ3mmXNWeTzrIDb GVuoc6jPkXAu7D3j15rUscjOKmJl4ykprSsnCOiUWM5Z55HNy8rYCjAwfrCqon7oYx f8uOlFUcNeNvAdLof3e7gy2z4ILDo+sVdELxe/hBLVp9yQV+ejpvMcJHgDrRyX5DSr LhAJw2FfF2zMGw2pVjKoZboAPx03EeKmN56dGCPAw9HiA9A905M+dUcNXnzfxLpUHx 7b8fdrUX6lKIw== Received: by mail-ot1-f51.google.com with SMTP id 61-20020a9d0d430000b02903eabfc221a9so7883043oti.0 for ; Fri, 27 Aug 2021 06:16:55 -0700 (PDT) X-Gm-Message-State: AOAM532Db0CSnx6O4m36Q0zUcay8GGzR7Rz/Wd5XijyrnYBeteVTpCr7 NMwdzivegeDnJE17oAjKYX2IGtFqhUscOEqyT5Q= X-Google-Smtp-Source: ABdhPJy6cuM8oa6qf/FcYhRx88hJstHfJvM2WNFL6S72MtmaJbFmhyRzUpYZxcZZ8T8bj7YnIScx4RHgZDWF5f4uZhA= X-Received: by 2002:a05:6830:124b:: with SMTP id s11mr8105834otp.90.1630070214798; Fri, 27 Aug 2021 06:16:54 -0700 (PDT) MIME-Version: 1.0 References: <20210823070925.10095-1-gary.lin@hpe.com> <67322735-0450-0128-8004-3946b44e8c58@suse.com> In-Reply-To: <67322735-0450-0128-8004-3946b44e8c58@suse.com> From: "Ard Biesheuvel" Date: Fri, 27 Aug 2021 15:16:43 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state To: Jim Fehlig Cc: Gary Lin , edk2-devel-groups-io , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Anthony Perard , Julien Grall , Joey Li Content-Type: text/plain; charset="UTF-8" On Tue, 24 Aug 2021 at 19:21, Jim Fehlig wrote: > > On 8/23/21 1:09 AM, Gary Lin wrote: > > When using HVM Direct kernel boot with OvmfXen, it could fail at the > > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > > and PcdAcpiS3Enable. > > > > This patch series initializes PcdAcpiS3Enable in > > . Besides, QemuFwCfgS3Enabled() is > > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the > > potential inconsistency. > > > > Bugzilla links: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > > > v3: > > - Update the description per Anthony's suggestion > > - Add the bugzilla links > > - Move the QemuKernelLoaderFsDxe patch out of this patch series > > and make it an independent patch > > v2: > > - Amend the description and address "HVM Direct Kernel Boot" > > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > > - Remove unused QemuFwCfgLib > > - Update my email address > > > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Anthony Perard > > Cc: Julien Grall > > Cc: Jim Fehlig > > Cc: Joey Li > > > > Gary Lin (4): > > OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization > > OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support > > OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 > > support > > OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support > > > > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > > .../PlatformBootManagerLib.inf | 1 + > > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ > > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ > > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > > .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- > > OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ > > 8 files changed, 22 insertions(+), 9 deletions(-) > > Tested-by: Jim Fehlig > Thanks for this series, and thanks all for the reviews. Gary, could you please resend it with the following changes so it applies cleanly: - Move the bugzilla link into the signoff block, preceded by Ref: - Remove v[23] etc version information from the patches, or move it below the three dashes line so it does not end up in the commit log - Incorporate all the review tags given in response to this v3 - Please find a way to send these patches that doesn't result in mangled whitespace (hint: using Outlook/Exchange is probably not the best choice) Thanks, Ard.