From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id BCF8BD80CAA for ; Mon, 15 Jul 2024 08:24:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Wgs3a0DEHMO1OL+HWw4BIvKWyYIgnOW+1xG2BdDNMj0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1721031878; v=1; b=IqNgepelpuCzatpI1tpov9RYAL4BBd3GNn9pDrSRNzO0PzUPyZnGi6/oBH047sJFBv8ig0mA bCyQAeLExD/LGy/QDlPeV/BPIZP+/ILzAhpkUJXXYy26AzYk8Y4pGCfZcFbdThoqhZwjMkaIJZ4 AGsvmFr9LhnBqNpT31SaMyYm+1y/4kxjoBRc2YL3iUIKWEkoW1OPldUBZkCe6aKu5MPZijTmsLo 9esHBX0Hw/CHJtV11PJvx/PcNn4QSDrrQWXrDiY1m4NcjiMiSk7l0YH7XlG1mtTQDivE/wdggUQ Ty8Wf+/dVewUQiLqolTKpSbM9Uoi+EQxUz1NmVpr2rAIQ== X-Received: by 127.0.0.2 with SMTP id RAf2YY7687511xueY4koqhaM; Mon, 15 Jul 2024 01:24:37 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.33345.1721031875917350730 for ; Mon, 15 Jul 2024 01:24:36 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A49F5CE0E10 for ; Mon, 15 Jul 2024 08:24:32 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0D3EC32782 for ; Mon, 15 Jul 2024 08:24:31 +0000 (UTC) X-Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-52ea79e6979so4483323e87.2 for ; Mon, 15 Jul 2024 01:24:31 -0700 (PDT) X-Gm-Message-State: cXWdiTVAUXiw3OdDK7FJJnDIx7686176AA= X-Google-Smtp-Source: AGHT+IFWcY26gqJjD12odezntoGn/Zoz0HvZ9Bh4n2WVLff2X70tsdx8LM1b899H+zXd3Gel8SQ6vF2ZwHwlBzdFRkQ= X-Received: by 2002:a05:6512:ad3:b0:52c:de8f:2e6c with SMTP id 2adb3069b0e04-52eb99da074mr14344611e87.57.1721031870349; Mon, 15 Jul 2024 01:24:30 -0700 (PDT) MIME-Version: 1.0 References: <20240712092356.517074-1-marcin.juszkiewicz@linaro.org> <20240712092356.517074-3-marcin.juszkiewicz@linaro.org> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 15 Jul 2024 10:24:18 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 2/2] SbsaQemu: set CPU model in SMBIOS To: Nhi Pham Cc: devel@edk2.groups.io, Marcin Juszkiewicz , Leif Lindholm , Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Jul 2024 01:24:36 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=IqNgepel; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Mon, 15 Jul 2024 at 05:25, Nhi Pham wrote: > > On 7/12/2024 5:01 PM, Ard Biesheuvel via groups.io wrote: > > On Fri, 12 Jul 2024 at 11:24, Marcin Juszkiewicz > > wrote: > >> > >> SbsaQemu platform have several cpu models available. Since start it > >> reported "arm-virt" one in SMBIOS instead of real one. > >> > >> This change replaces it with the real cpu model like Cortex-A57, > >> Neoverse-N2 etc. > >> > >> Requires change in EDK2 to make PcdProcessorVersion dynamic. > >> > >> Signed-off-by: Marcin Juszkiewicz > > > > I am going to make the same remark as I did before in a different > > context: how is it guaranteed that the code that sets the PCD executes > > before the code that consumes it? > > We could implement the setting in a 'PlatformInitDxe', which will be > added to the 'APPRIORI DXE' list to ensure it is scheduled to run in the > early DXE phase. This approach will help initialize the neccessary > compoenents early in the DXE phase, providing a stable foundation for > subsequent operations. > APRIORI DXE should be avoided, so I don't want to see it used in a reference implementation. (APRIORI DXE breaks the DXE dependency based dispatch) > > > > Making PCDs dynamic is usually not the solution here, unless they are > > set in the PEI phase and consumed in the DXE phase or after. > > > > The EFI SMBIOS protocol has an 'update string' method that you can > > call from a platform driver. That might be a better fit here, and the > > PCD can remain fixed, and carry a fallback default value. > > > > In fact that the 'update string' method could eat up the boot time. > Hence, the SMBIOS string patching is not prefered. > Let's implement it correctly first, and then, if boot time appears to be impacted, think about how to optimize this. Boot time is not a huge concern for an emulator. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119933): https://edk2.groups.io/g/devel/message/119933 Mute This Topic: https://groups.io/mt/107179083/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-