Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 4 May 2023 at 12:13, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Ping.
>

I'll pick these up - thanks for the reminder.


> On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote:
> > ArmVirtXen.dsc allows setting the firmware version
> > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
> > via FIRMWARE_VER variable conveniently on the build command line.
> >
> > These two patches add this behavior to all .dsc files in ArmVirtPkg
> > and OvmfPkg.
> >
> > PR: https://github.com/tianocore/edk2/pull/4268
> >
> > v4:
> > - Actually use the include file
> >
> > v3:
> > - Introduce common include file for OVMF .dsc files
> > https://edk2.groups.io/g/devel/message/102952
> >
> > v2:
> > Address comments by Sami and Gerd:
> > - Only set PCD if FIRMWARE_VER is defined
> > - ArmVirt: move logic to ArmVirt.dsc.inc
> > https://edk2.groups.io/g/devel/message/95208
> >
> > v1:
> > https://edk2.groups.io/g/devel/message/95057
> >
> > Oliver Steffen (2):
> >   OvmfPkg: allow setting Firmware Version from build command line
> >   ArmVirtPkg: allow setting Firmware Version from build command line
> >
> >  ArmVirtPkg/ArmVirt.dsc.inc          | 4 ++++
> >  OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++
> >  ArmVirtPkg/ArmVirtXen.dsc           | 1 -
> >  OvmfPkg/OvmfPkgIa32.dsc             | 2 ++
> >  OvmfPkg/OvmfPkgIa32X64.dsc          | 2 ++
> >  OvmfPkg/OvmfPkgX64.dsc              | 3 +++
> >  OvmfPkg/OvmfXen.dsc                 | 2 ++
> >  7 files changed, 22 insertions(+), 1 deletion(-)
> >  create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc
> >
> > --
> > 2.40.0
> >
>
> --
>
>
>
> 
>
>