From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.46756.1683197716592191590 for ; Thu, 04 May 2023 03:55:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uf3tfSff; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E71CB6333B for ; Thu, 4 May 2023 10:55:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA6CAC433A4 for ; Thu, 4 May 2023 10:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683197715; bh=AMSWF0gBasrdn0RJLWe0DZa9fxL4jIEqlJnrSmFIoDY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uf3tfSffAxIW23K5AlGojQgzlPQX4/fn4w6OMx5kpuXHorsDuLJgcuZ1TfVvm7bS0 xWRB4wbZNTMiuCSwOb71eqFGQ5ehNSBWMB0t10MDy6R4k6Mwq5BmrjrAW8oCbsII3o qf5Xnxv/Hnpc9g7TYnJcQTUFZ7Qbm1xo7oUmvhbRJyHx93/v+M6tFZhX31/u+ivFE8 r1LoeCZ3rpPinZTqU7pm4L1Kj2VN0HTV01cauv79cf0PnMiprUAM+11SM+ZfIPWfhB 13U8+EwQ7ZeakmpybroBNb924CfU/c9Y2+RsfTApVxZBx36sirCUiRpgmVe+I7lgCI idJhIAkESb+Ig== Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-4f004943558so379245e87.3 for ; Thu, 04 May 2023 03:55:14 -0700 (PDT) X-Gm-Message-State: AC+VfDxxhLOz4y7xUSXxdUGtMjaeS/NSvjGTBT9ecpX7n5MCKivYbIkK OLkHdKtGW8V7RR9iV9lUsfc9MG2Qi+8OoC+SaEI= X-Google-Smtp-Source: ACHHUZ542+JKHEdjwl+3At3H4CLCzQjKuL3WAqpYTvPKeu8CjR0qIgE2OGI/v5NzR4h0Viq5WORfDoP60AXqfWdVZBA= X-Received: by 2002:ac2:4257:0:b0:4ec:a04e:5dcd with SMTP id m23-20020ac24257000000b004eca04e5dcdmr1485527lfl.61.1683197712744; Thu, 04 May 2023 03:55:12 -0700 (PDT) MIME-Version: 1.0 References: <20230414083323.153731-1-osteffen@redhat.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 4 May 2023 12:55:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line To: devel@edk2.groups.io, kraxel@redhat.com Cc: Oliver Steffen , Anthony Perard , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Ray Ni , Sami Mujawar , Zhichao Gao Content-Type: text/plain; charset="UTF-8" On Thu, 4 May 2023 at 12:13, Gerd Hoffmann wrote: > > Ping. > I'll pick these up - thanks for the reminder. > On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote: > > ArmVirtXen.dsc allows setting the firmware version > > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > > via FIRMWARE_VER variable conveniently on the build command line. > > > > These two patches add this behavior to all .dsc files in ArmVirtPkg > > and OvmfPkg. > > > > PR: https://github.com/tianocore/edk2/pull/4268 > > > > v4: > > - Actually use the include file > > > > v3: > > - Introduce common include file for OVMF .dsc files > > https://edk2.groups.io/g/devel/message/102952 > > > > v2: > > Address comments by Sami and Gerd: > > - Only set PCD if FIRMWARE_VER is defined > > - ArmVirt: move logic to ArmVirt.dsc.inc > > https://edk2.groups.io/g/devel/message/95208 > > > > v1: > > https://edk2.groups.io/g/devel/message/95057 > > > > Oliver Steffen (2): > > OvmfPkg: allow setting Firmware Version from build command line > > ArmVirtPkg: allow setting Firmware Version from build command line > > > > ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++ > > OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++ > > ArmVirtPkg/ArmVirtXen.dsc | 1 - > > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > > OvmfPkg/OvmfPkgX64.dsc | 3 +++ > > OvmfPkg/OvmfXen.dsc | 2 ++ > > 7 files changed, 22 insertions(+), 1 deletion(-) > > create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc > > > > -- > > 2.40.0 > > > > -- > > > > > >