From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.7062.1675150322526789651 for ; Mon, 30 Jan 2023 23:32:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nleLZ6ZC; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1C1461422 for ; Tue, 31 Jan 2023 07:32:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32A96C4339C for ; Tue, 31 Jan 2023 07:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675150321; bh=rJzMIYqdYDhbZ2+4nbfKeu/a9U4tNe9b5VdFE0pHDto=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nleLZ6ZCA1Gwwta1FmVfBQpCt9VHdek7sqOvxQAi2tWyWK7wgoip7sDGZIIP3NsBJ szB2iW1fqvG7WwDg61YoGkxtPNkQuvyNrvDq3UR70VlqYsMTOgiuglHOonK6ezFFlM gKcddTaOA+kjg+UFBw4NWIuo3aHfaxJZQf8CBZY9XUoOqChvTZuOLhrmPH36pv+DGS TI97bhJL1Ycvcq2PoHgpX4Ec5xfR0+GNgCXzRHU/MXpeGooFTFT7X88IJfUORZLG27 XuUBwX0FuJp2kHJ3LizeCvR1Z+YJlQ1yjO3dhixzNDVdsLwof3uuyiHB+C55JbgMB6 U+kpHvXzk0s+w== Received: by mail-lj1-f173.google.com with SMTP id o5so350914ljj.1 for ; Mon, 30 Jan 2023 23:32:01 -0800 (PST) X-Gm-Message-State: AO0yUKVPJpipAsLV30mgTVAQxQ2HHb7YL/a1O0pVXtMv2duDXp6kZB92 5wo1yzwqp0eHFRReHVAUiyedyamA8V+2SG5bxMk= X-Google-Smtp-Source: AK7set87KAPKv6wTpD+cjJST3om8GvsDyDcveasdnRF8jq63z3ZDeOFu0JQazrsfRWhQW7qecuhPe/S238PL2Yryrk8= X-Received: by 2002:a2e:8554:0:b0:290:52de:f541 with SMTP id u20-20020a2e8554000000b0029052def541mr1167173ljj.80.1675150319196; Mon, 30 Jan 2023 23:31:59 -0800 (PST) MIME-Version: 1.0 References: <20230131054518.1576-1-aryeh.chen@intel.com> In-Reply-To: <20230131054518.1576-1-aryeh.chen@intel.com> From: "Ard Biesheuvel" Date: Tue, 31 Jan 2023 08:31:47 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 To: devel@edk2.groups.io, aryeh.chen@intel.com Cc: Chasel Chiu , Nate DeSimone , Isaac Oram , Liming Gao , Eric Dong Content-Type: text/plain; charset="UTF-8" On Tue, 31 Jan 2023 at 06:46, Chen, Aryeh wrote: > > From: Aryeh Chen > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329 > > To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 > on MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to > \_SB.PC00 since Client ADL platform. > > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong Why is this needed? > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4 ++++ > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 + > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++ > 3 files changed, 8 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 4efb8709ac..b7361b6d44 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -23,7 +23,11 @@ DefinitionBlock ( > //--------------------------------------------------------------------------- > // Begin PCI tree object scope > //--------------------------------------------------------------------------- > +#if FixedPcdGetBool (PcdMinPciBridgePC00) == 1 > + Device(PC00) { // PCI Bridge "Host Bridge" > +#else > Device(PCI0) { // PCI Bridge "Host Bridge" > +#endif > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy > Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID > Name(_SEG, 0) > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > index 3437bc489c..b3b45039cc 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > @@ -40,6 +40,7 @@ > [Pcd] > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 > > [Depex] > gEfiAcpiTableProtocolGuid AND > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..68a76db4de 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -139,6 +139,9 @@ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UINT8|0x00010056 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 > > + # The PCD controls MinDsdt PciBridge > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x00010057 > + > # > # FADT Duty Offset - The zero-based index of where the processor's duty cycle > # setting is within the processor's P_CNT register. > -- > 2.26.2.windows.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#99338): https://edk2.groups.io/g/devel/message/99338 > Mute This Topic: https://groups.io/mt/96647478/1131722 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > ------------ > >