From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Bob Feng <bob.c.feng@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>, Andrew Fish <afish@apple.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38
Date: Wed, 22 Mar 2023 13:32:01 +0100 [thread overview]
Message-ID: <CAMj1kXGGJLeeqFFWe4KiHKW=LPd+w2Kf18pEsapH6Z9k8qqJKw@mail.gmail.com> (raw)
In-Reply-To: <a3f851d2-4d1b-57d2-78ea-7e70b844c2a6@bsdio.com>
On Wed, 22 Mar 2023 at 13:28, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> On 3/22/23 5:49 AM, Ard Biesheuvel wrote:
>
> > The reason I added CLANG3x support for ARM in the past is to ensure
> > compatibility with the ARM proprietary, Clang based toolchain. At the
> > time, we went with GNU ld, but I would actually prefer if we could
> > make this work with LLD as well.
> >
> > I can work around this issue locally by doing
> >
> > --- a/OvmfPkg/OvmfPkgX64.dsc
> > +++ b/OvmfPkg/OvmfPkgX64.dsc
> > @@ -297,7 +297,7 @@
> > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
> > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> > -!if $(TOOL_CHAIN_TAG) == "XCODE5"
> > +!if $(TOOL_CHAIN_TAG) == "XCODE5" || $(TOOL_CHAIN_TAG) == "CLANGDWARF"
> > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf
> > !else
> >
> > Can you please check whether this works for you as well?
>
> Thanks, that works here too!
>
> Do we still need to keep CLANG35 and CLANG38 toolchains for
> compatibility with the ARM toolchain? Or have things moved on so they
> _can_ be removed?
>
No, please go ahead and merge all of those - the 35/38 naming is so
out of date it is likely to confuse people, so we should rename those
in any case.
I haven't tried building EDK2 for ARM with LLD myself - let me know if
you run into any issues there.
next prev parent reply other threads:[~2023-03-22 12:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 1:30 [PATCH 0/9] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38 and update CLANGDWARF, delete VS 2008-2013, EBC Rebecca Cran
2023-03-22 1:30 ` [PATCH 1/9] OvmfPkg: Replace static struct initialization with ZeroMem call Rebecca Cran
2023-03-22 5:55 ` Gerd Hoffmann
2023-03-22 1:30 ` [PATCH 2/9] CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler flags Rebecca Cran
2023-03-22 1:30 ` [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 Rebecca Cran
2023-03-22 4:57 ` [edk2-devel] " Guo, Gua
2023-03-22 13:10 ` Rebecca Cran
2023-03-22 22:07 ` Guo, Gua
2023-03-22 22:23 ` Rebecca Cran
2023-03-22 22:46 ` Guo, Gua
2023-03-27 22:15 ` Rebecca Cran
2023-03-22 11:49 ` Ard Biesheuvel
2023-03-22 12:28 ` [edk2-devel] " Rebecca Cran
2023-03-22 12:32 ` Ard Biesheuvel [this message]
2023-03-22 13:03 ` Gerd Hoffmann
2023-03-22 13:05 ` Ard Biesheuvel
2023-03-23 1:30 ` Rebecca Cran
2023-03-23 9:04 ` Ard Biesheuvel
2023-03-23 13:14 ` Ard Biesheuvel
2023-03-22 1:30 ` [PATCH 4/9] BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions Rebecca Cran
2023-03-22 1:30 ` [PATCH 5/9] BaseTools: Remove VS2008-VS2013 remnants Rebecca Cran
2023-03-22 1:30 ` [PATCH 6/9] MdePkg: " Rebecca Cran
2023-03-22 1:30 ` [PATCH 7/9] edksetup.bat: " Rebecca Cran
2023-03-22 1:30 ` [PATCH 8/9] BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs Rebecca Cran
2023-03-22 1:30 ` [PATCH 9/9] BaseTools: Remove EBC (EFI Byte Code) compiler definitions Rebecca Cran
2023-03-22 9:04 ` [PATCH 0/9] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38 and update CLANGDWARF, delete VS 2008-2013, EBC Ard Biesheuvel
2023-03-22 16:37 ` [edk2-devel] " Oliver Smith-Denny
2023-03-23 1:05 ` 回复: " gaoliming
2023-03-23 1:10 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGGJLeeqFFWe4KiHKW=LPd+w2Kf18pEsapH6Z9k8qqJKw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox