From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.41436.1679488336710018398 for ; Wed, 22 Mar 2023 05:32:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q6YHaDMS; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D61D620AA for ; Wed, 22 Mar 2023 12:32:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9659C433AE for ; Wed, 22 Mar 2023 12:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679488334; bh=FqySRaf2Ipzi7hfOVSiV/rOuR+IrkW0K6hZQKRf/O5A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Q6YHaDMSdOkKbtHhoHMtg8FHpilsKyl6oXvKqFPGm3iEUj8ZakhyER/Kdo5sFrPYz s4rKkswEfZGf86cz8ihL8Aa3PE+B8C6kkyIDM6+SeciPaHoAFxRFzd+fZfRm+o5JQN PbD09phHaD34ZKY6nMh9Ltn2m9kA2M51L4yTs95EgHQKiEG1H8sw6WBJIZBpcRIdex RNB15WBwl9+ofta+5JqMBZfyG/KIyFPEFIyTfg0xbQ1sJ2HJuYUNGOkzuAFIXc7Hxg /Ek2Qhz6r63ehAEA+3m65mFmlfuDNEi7xlZY/4iwtOqgmxZLPiHRsxefCJK+Sf9rqw eXdJkQR+O5Agg== Received: by mail-lf1-f50.google.com with SMTP id c29so5708768lfv.3 for ; Wed, 22 Mar 2023 05:32:14 -0700 (PDT) X-Gm-Message-State: AO0yUKXqQ9GsFy1gElyz6tHdgaxyCuAWgZrI6xUtHB/9O5nJ7dY5KqOt 8Efc3iT57B1bomgiSGUwVhcRTAkk69huMgxcGDA= X-Google-Smtp-Source: AK7set/REPigIqPJpvN8noVld9k+xoSayLPOZDXGKD1oaGGh9kY3FSClDkka+Kf69R+gMyfS7jfsN/XDv3Yaei1klZc= X-Received: by 2002:ac2:5dee:0:b0:4d5:ca42:e43b with SMTP id z14-20020ac25dee000000b004d5ca42e43bmr1921125lfq.4.1679488332707; Wed, 22 Mar 2023 05:32:12 -0700 (PDT) MIME-Version: 1.0 References: <20230322013040.3322865-1-rebecca@bsdio.com> <20230322013040.3322865-4-rebecca@bsdio.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 22 Mar 2023 13:32:01 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 To: Rebecca Cran Cc: devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Bob Feng , Yuwei Chen , Andrew Fish , Leif Lindholm , Ard Biesheuvel , Jordan Justen , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" On Wed, 22 Mar 2023 at 13:28, Rebecca Cran wrote: > > On 3/22/23 5:49 AM, Ard Biesheuvel wrote: > > > The reason I added CLANG3x support for ARM in the past is to ensure > > compatibility with the ARM proprietary, Clang based toolchain. At the > > time, we went with GNU ld, but I would actually prefer if we could > > make this work with LLD as well. > > > > I can work around this issue locally by doing > > > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -297,7 +297,7 @@ > > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > > -!if $(TOOL_CHAIN_TAG) == "XCODE5" > > +!if $(TOOL_CHAIN_TAG) == "XCODE5" || $(TOOL_CHAIN_TAG) == "CLANGDWARF" > > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf > > !else > > > > Can you please check whether this works for you as well? > > Thanks, that works here too! > > Do we still need to keep CLANG35 and CLANG38 toolchains for > compatibility with the ARM toolchain? Or have things moved on so they > _can_ be removed? > No, please go ahead and merge all of those - the 35/38 naming is so out of date it is likely to confuse people, so we should rename those in any case. I haven't tried building EDK2 for ARM with LLD myself - let me know if you run into any issues there.