public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>,
	 Abdul Lateef Attar <AbdulLateef.Attar@amd.com>,
	Abner Chang <abner.chang@amd.com>,
	 Chuong Tran <chuong@os.amperecomputing.com>,
	Graeme Gregory <graeme@xora.org.uk>,
	 Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
	Marcin Wojtas <marcin.s.wojtas@gmail.com>,
	 Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
	Narinder Dhillon <ndhillon@marvell.com>,
	 Nhi Pham <nhi@os.amperecomputing.com>,
	Paul Grimes <paul.grimes@amd.com>,
	 Rebecca Cran <rebecca@os.amperecomputing.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	 Thomas Abraham <thomas.abraham@arm.com>,
	Wenyi Xie <xiewenyi2@huawei.com>,
	 Ling Jia <jialing@phytium.com.cn>,
	Peng Xie <xiepeng@phytium.com.cn>,
	 Yiqi Shu <shuyiqi@phytium.com.cn>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec
Date: Thu, 1 Aug 2024 16:44:03 +0200	[thread overview]
Message-ID: <CAMj1kXGHXcJJEw1dex83+C+gALSN9qrXNXQ6BLM+QSTjVre36Q@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXFXXmAecHUHNY=EapWUZ2n4B2U59=wzm-tX1j-Yo7EKOA@mail.gmail.com>

On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > Hi,
> >
> > On 7/31/24 11:33, Ard Biesheuvel wrote:
> > > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> > > to the new versions called Sec or PeilessSec - these have been cleaned
> > > up and stripped of obsolete functionality related to multicore boot,
> > > which is not something UEFI should concern itself with.
> > >
> > > This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> > > After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> > > can be retired.
> >
> >
> > Hi,
> >
> > Thanks for cleaning this up, but the rpi4 fails with:
> >
> > Decompress GetInfo Failed - Invalid Parameter
> >
> > ASSERT_EFI_ERROR (Status = Not Found)
> > ASSERT [PeilessSec]
> > /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
> > !(((INTN)(RETURN_STATUS)(Status)) < 0)
> >
>
> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
>
> I'll look into it.

The below should fix it - I'll update all DSCs with this if it works
for you as well.

--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -193,7 +193,6 @@ [LibraryClasses.common.SEC]
   MemoryInitPeiLib|Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf
   PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
   ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
-  LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
   PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
   HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
   PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
@@ -604,6 +603,7 @@ [Components.common]
   #
   ArmPlatformPkg/PeilessSec/PeilessSec.inf {
     <LibraryClasses>
+      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
       SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.inf
   }


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120177): https://edk2.groups.io/g/devel/message/120177
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-08-01 14:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 16:33 [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec Ard Biesheuvel
2024-07-31 16:33 ` [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf Ard Biesheuvel
2024-08-01 15:25   ` Nhi Pham via groups.io
2024-08-05 19:14   ` Marcin Juszkiewicz
2024-08-06 14:08     ` Leif Lindholm
2024-07-31 16:33 ` [edk2-devel] [PATCH edk2-platforms 2/2] Platform AARCH64: Move PrePi users to PeilessSec.inf Ard Biesheuvel
2024-08-01  9:21 ` [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec Sami Mujawar
2024-08-01 13:49 ` Jeremy Linton
2024-08-01 14:11   ` Ard Biesheuvel
2024-08-01 14:44     ` Ard Biesheuvel [this message]
2024-08-01 15:19       ` Jeremy Linton
2024-08-01 15:43         ` Ard Biesheuvel
2024-08-01 15:50           ` Rebecca Cran
2024-08-01 15:54             ` Ard Biesheuvel
2024-08-01 18:50             ` Jeremy Linton
2024-08-02 11:44               ` Rebecca Cran
2024-08-05 16:17                 ` Jeremy Linton
2024-08-06 14:10         ` Leif Lindholm
2024-08-27 16:37           ` Ard Biesheuvel via groups.io
2024-08-28  3:54             ` Jeremy Linton
2024-08-28  7:54               ` Ard Biesheuvel via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXGHXcJJEw1dex83+C+gALSN9qrXNXQ6BLM+QSTjVre36Q@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox