Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > Hi,
> >
> > On 7/31/24 11:33, Ard Biesheuvel wrote:
> > > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
> > > to the new versions called Sec or PeilessSec - these have been cleaned
> > > up and stripped of obsolete functionality related to multicore boot,
> > > which is not something UEFI should concern itself with.
> > >
> > > This series can be merged once Tianocore/edk2 PR #5997 is merged first.
> > > After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
> > > can be retired.
> >
> >
> > Hi,
> >
> > Thanks for cleaning this up, but the rpi4 fails with:
> >
> > Decompress GetInfo Failed - Invalid Parameter
> >
> > ASSERT_EFI_ERROR (Status = Not Found)
> > ASSERT [PeilessSec]
> > /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
> > !(((INTN)(RETURN_STATUS)(Status)) < 0)
> >
>
> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
>
> I'll look into it.

The below should fix it - I'll update all DSCs with this if it works
for you as well.

--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -193,7 +193,6 @@ [LibraryClasses.common.SEC]
   MemoryInitPeiLib|Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf
   PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
   ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
-  LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
   PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
   HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
   PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
@@ -604,6 +603,7 @@ [Components.common]
   #
   ArmPlatformPkg/PeilessSec/PeilessSec.inf {
     <LibraryClasses>
+      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
       SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.inf
   }


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120177): https://edk2.groups.io/g/devel/message/120177
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-