From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id D29FA941804 for ; Thu, 1 Aug 2024 14:44:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Um61OA8mNnYztR0FsIETQvWuQubSqZhFnRfgLl4Qeoo=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1722523459; v=1; b=L2xju2fZuyL2UunpKXSBPEOzP2sBt3vlg3QlT6yA2xmH4Jpv7Zl0kIF43V9PxjQe7LFxQ0u0 HZAKolPHqQK0NOHcF8UB0enYZPjkAuhSnNmexXHzzsC05jh2rqMABBPC/GE7tGWrEByBG7VFLZL ihwyRIFm9pipBTRxU8p0RPYgVijhRmF538+oAWhAAph8c3+T8RnjOPYIJmS8Mm9RjuMLdDoGGid 9RfAZzACD/8r8ZW6R19x+BdiBAmY2zQjpOjq3EGGaRZ3sfzht9CatGC0zwmvzMZfJCtzaxMA5+k 5TxnAq7G2T+XKyxUVEdsBFuVYVjAnqvRSsHGUOgWtkJiA== X-Received: by 127.0.0.2 with SMTP id WDQIYY7687511xhABjYhxdru; Thu, 01 Aug 2024 07:44:18 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.70051.1722523457659263287 for ; Thu, 01 Aug 2024 07:44:17 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F2B94628BF for ; Thu, 1 Aug 2024 14:44:16 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7E0AC4AF0B for ; Thu, 1 Aug 2024 14:44:16 +0000 (UTC) X-Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52efaae7edfso7346540e87.2 for ; Thu, 01 Aug 2024 07:44:16 -0700 (PDT) X-Gm-Message-State: 9lMbJTV3xRpOo60DcXGXA1hqx7686176AA= X-Google-Smtp-Source: AGHT+IGHygZ6OD1jqZqFxHOsBovLJRFIoTp5jWK8Ib1BiECVhvdBWbCvXnCi5cCTzJ2NkkPLU5QfaL3lmfHRZs0J0gE= X-Received: by 2002:a05:6512:2249:b0:52e:9f6b:64 with SMTP id 2adb3069b0e04-530bb3b6fcemr51671e87.34.1722523455040; Thu, 01 Aug 2024 07:44:15 -0700 (PDT) MIME-Version: 1.0 References: <20240731163334.6979-1-ardb@kernel.org> <841a1869-2cd4-4ba4-aea0-12b2f1b90d86@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 1 Aug 2024 16:44:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec To: Jeremy Linton Cc: devel@edk2.groups.io, Leif Lindholm , Abdul Lateef Attar , Abner Chang , Chuong Tran , Graeme Gregory , Marcin Juszkiewicz , Marcin Wojtas , Meenakshi Aggarwal , Narinder Dhillon , Nhi Pham , Paul Grimes , Rebecca Cran , Sami Mujawar , Thomas Abraham , Wenyi Xie , Ling Jia , Peng Xie , Yiqi Shu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 01 Aug 2024 07:44:17 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=L2xju2fZ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: > > On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: > > > > Hi, > > > > On 7/31/24 11:33, Ard Biesheuvel wrote: > > > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg > > > to the new versions called Sec or PeilessSec - these have been cleaned > > > up and stripped of obsolete functionality related to multicore boot, > > > which is not something UEFI should concern itself with. > > > > > > This series can be merged once Tianocore/edk2 PR #5997 is merged first. > > > After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers > > > can be retired. > > > > > > Hi, > > > > Thanks for cleaning this up, but the rpi4 fails with: > > > > Decompress GetInfo Failed - Invalid Parameter > > > > ASSERT_EFI_ERROR (Status = Not Found) > > ASSERT [PeilessSec] > > /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158): > > !(((INTN)(RETURN_STATUS)(Status)) < 0) > > > > Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild. > > I'll look into it. The below should fix it - I'll update all DSCs with this if it works for you as well. --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -193,7 +193,6 @@ [LibraryClasses.common.SEC] MemoryInitPeiLib|Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf - LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf @@ -604,6 +603,7 @@ [Components.common] # ArmPlatformPkg/PeilessSec/PeilessSec.inf { + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.inf } -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120177): https://edk2.groups.io/g/devel/message/120177 Mute This Topic: https://groups.io/mt/107649429/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-