From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.51647.1680259770134267251 for ; Fri, 31 Mar 2023 03:49:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NTrbVDXW; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C3D8627CE for ; Fri, 31 Mar 2023 10:49:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0AE3C4339B for ; Fri, 31 Mar 2023 10:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680259769; bh=M8LokLRPhf5wXLTMH1wfIOXIRWycoXjrq2fkZx/Ec/Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NTrbVDXWFywvRdDX0vgc/CiCZGsI6tCEBm0yTbPIk0L+x3xFtbEMhSGJxDtF+ieiH aMZ+g8MI/SoIGVvADFOZ2Xomi8B1TWbJRt9rBaX9jgx6XStlSnEfSJfehsSPPOuYhF JIB8x4hztGSQfohBzBQRzWQT6xtv+GI11c44YKBR9RfM1Kd+2sfcbGISx9ewWTTgv0 md2iPH13v7I5YWdnCfpaGAlfGXCUEvZPgiJFdpDhlraqcgEEs4nQ6Ce+xM/glX94By 0KWkZTNDKk1dSVpUDVXlT04GcZK/OXUD6F0M0O6sxxhVLPkINP3EZC8g3NR++Wh9DR XAM+MnbIkadjw== Received: by mail-lj1-f174.google.com with SMTP id a44so3912644ljr.10 for ; Fri, 31 Mar 2023 03:49:28 -0700 (PDT) X-Gm-Message-State: AAQBX9dyRPtTwFgwLxMe6nQBJH9PBB+4b3CdYQGUNaD/v3t8KJIh8Y4J hlZJf1R+bT4L1cZRp4d17bsg4CzvaqQYZwAxcvQ= X-Google-Smtp-Source: AKy350ZategL1NnpJVsERTTLhoMuHXFlR5bFqQqFEphsd0dzWD8bed8IifuSUMrBckoIHbcFcYU0o+scKB0pcBv5EYc= X-Received: by 2002:a2e:9c11:0:b0:298:bddc:dbbf with SMTP id s17-20020a2e9c11000000b00298bddcdbbfmr7967304lji.2.1680259766971; Fri, 31 Mar 2023 03:49:26 -0700 (PDT) MIME-Version: 1.0 References: <20230331091437.1593337-1-ardb@kernel.org> <20230331091437.1593337-3-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 31 Mar 2023 12:49:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version To: "Ni, Ray" Cc: "devel@edk2.groups.io" , Andrew Fish , "Kinney, Michael D" , "Liu, Zhiguang" , Rebecca Cran , Tom Lendacky , =?UTF-8?Q?Marvin_H=C3=A4user?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 31 Mar 2023 at 12:19, Ni, Ray wrote: > > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Friday, March 31, 2023 6:13 PM > > To: devel@edk2.groups.io; Ni, Ray > > Cc: Andrew Fish ; Kinney, Michael D > > ; Liu, Zhiguang ; > > Rebecca Cran ; Tom Lendacky > > ; Marvin H=C3=A4user > > Subject: Re: [edk2-devel] [RFT PATCH v3 2/5] > > UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version > > > > On Fri, 31 Mar 2023 at 11:56, Ni, Ray wrote: > > > > > > Ard, > > > Thanks for the detailed commit messages. That really helps me to > > understand why XCODE version > > > was needed. > > > > > > However, I feel it would be great if you can "highlight" what are cha= nged by > > this patch. > > > The following is just an example. You can reword as you like. > > > > > > 1. Change for non-XCODE SecPeiCpuExceptionHandlerLib: > > > * Use SecPeiExceptionHandlerAsm.nasm (renamed from > > ExceptionHandlerAsm.nasm) > > > * Removed some unnecessary absolute references > > > * (32 IDT stubs are still in .text.) > > > > Indeed > > > > > 2. Change for XCODE SecPeiCpuExceptionHandlerLib: > > > * Use SecPeiExceptionHandlerAsm.nasm instead of > > Xcode5ExceptionHandlerAsm.nasm > > > * CET logic is not in SecPeiExceptionHandlerAsm.nasm (but aligns t= o non- > > XCODE lib instance) > > > > No, this does not actually change in this patch. The CET logic does > > not exist in the generic SecPei version either before or after this > > patch. > > Because of this patch, CET logic is removed from XCODE SecPeiCpuException= HandlerLib. Indeed - I will make that clear in the commit log.