From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.22487.1662364448694738937 for ; Mon, 05 Sep 2022 00:54:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MlUIOLSz; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7E22CB80ECE for ; Mon, 5 Sep 2022 07:54:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B36AC433B5 for ; Mon, 5 Sep 2022 07:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662364445; bh=py6Gw6JmL3Am5AJWb69cwpdSWl9+EQPpqzS2ePWcNlg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MlUIOLSzjUXYtJuVfuKPPM/4G+cRL2b9UcWqrYhgHUrQ43WN5BroxUKX1TLDnfv7l WZ/DN+ddMDni5OjrwUomhZK9LJHJl2Z7U+Xn/82BKZyq4KYNnVfXW1A5DaFNH3ckmo I7o4q2tynCgxr6antAMVBKYssuqwPPPTVBL6e1O5AZ22YIB8dj/Q96tjCVnJwvvwIl 2+5P4+e8Q5LMbM9I5L/QtBPll7WbUrAhwaCrjpcMTZW1bqXVJGfEeIP0wl0w+hqZWL 8dqFcxc4IkVvZuathWep6dKBxoFYNESILhBuELYlN/+n0uGYKA/fFcbhD30FKJ0M5g ACnIBYEbhkGKg== Received: by mail-lf1-f54.google.com with SMTP id q7so11966326lfu.5 for ; Mon, 05 Sep 2022 00:54:05 -0700 (PDT) X-Gm-Message-State: ACgBeo2rjB2nKqtHnCc5XXw5a5cYTE3N/+kSKprCD4KG3HyZmbMtl7c/ D40/bW1ppovW9zFEoUdsmvkL5sX1hx6q238n8YM= X-Google-Smtp-Source: AA6agR5NDacPJVMjyK54OsOKCdyVxKhoLkyhxbSqTcMSUJjMw2SaUJpHIZeKkwZ87lbvg5JfPF+CQzy+9dTqKqFofRk= X-Received: by 2002:a05:6512:402:b0:494:78bb:f538 with SMTP id u2-20020a056512040200b0049478bbf538mr9634555lfk.637.1662364443233; Mon, 05 Sep 2022 00:54:03 -0700 (PDT) MIME-Version: 1.0 References: <20220902222206.1509-1-mikuback@linux.microsoft.com> <20220902222206.1509-9-mikuback@linux.microsoft.com> In-Reply-To: <20220902222206.1509-9-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Mon, 5 Sep 2022 09:53:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 8/8] OvmfPkg/LegacyBootManagerLib: Fix debug macro arguments To: mikuback@linux.microsoft.com Cc: devel@edk2.groups.io, Jiewen Yao , Jordan Justen , Gerd Hoffmann , David Woodhouse Content-Type: text/plain; charset="UTF-8" On Sat, 3 Sept 2022 at 00:23, wrote: > > From: Michael Kubacki > > The DEBUG macro updated in this patch previously contained 11 print > specifiers in the debug string but passeed 13 arguments. This change > attempts to update the macro to the author's intention so the number > of specifiers match the number of arguments. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: David Woodhouse > Signed-off-by: Michael Kubacki Reviewed-by: Ard Biesheuvel > --- > OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c b/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c > index 032aacba68de..2e92bce726a9 100644 > --- a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c > +++ b/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c > @@ -1159,8 +1159,8 @@ LegacyBmPrintBbsTable ( > UINT16 Index; > > DEBUG ((DEBUG_INFO, "\n")); > - DEBUG ((DEBUG_INFO, " NO Prio bb/dd/ff cl/sc Type Stat segm:offs\n")); > - DEBUG ((DEBUG_INFO, "=============================================\n")); > + DEBUG ((DEBUG_INFO, " NO Prio bb/dd/ff cl/sc Type Stat segm:offs mseg dseg\n")); > + DEBUG ((DEBUG_INFO, "======================================================\n")); > for (Index = 0; Index < BbsCount; Index++) { > if (!LegacyBmValidBbsEntry (&LocalBbsTable[Index])) { > continue; > @@ -1168,7 +1168,7 @@ LegacyBmPrintBbsTable ( > > DEBUG ( > (DEBUG_INFO, > - " %02x: %04x %02x/%02x/%02x %02x/%02x %04x %04x %04x:%04x\n", > + " %02x: %04x %02x/%02x/%02x %02x/%02x %04x %04x %04x:%04x %04x %04x\n", > (UINTN)Index, > (UINTN)LocalBbsTable[Index].BootPriority, > (UINTN)LocalBbsTable[Index].Bus, > -- > 2.28.0.windows.1 >