From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 497579416AB for ; Thu, 10 Aug 2023 11:18:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GEitQmESt/6F+YGTxXw9p2xr6ZcRWtP7wuLVwWC00Xg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691666308; v=1; b=Y+5JIIGa6gk9ImGmLlyAPpRXxuGwEmPBV1jNDxOYAlXCrmPVVRJXbQOl/ylAVtOZU60cf1Dq +E3a/bFWbJjN2LM0UqBBAkkHoz+46ndj6ED6PpreQlZKjff4EzVGreJ1gIpr3vUYteJPo5ZSBPa BJx3OWm8rcnhrhqOLt7L+aks= X-Received: by 127.0.0.2 with SMTP id cXasYY7687511xTVUdIdX29I; Thu, 10 Aug 2023 04:18:28 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.14717.1691666308134634052 for ; Thu, 10 Aug 2023 04:18:28 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D12560C90 for ; Thu, 10 Aug 2023 11:18:27 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id E468CC433CB for ; Thu, 10 Aug 2023 11:18:26 +0000 (UTC) X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-4fe85fd3d27so1209633e87.0 for ; Thu, 10 Aug 2023 04:18:26 -0700 (PDT) X-Gm-Message-State: UzRADyjmTsIw3QTq2xpr5MYDx7686176AA= X-Google-Smtp-Source: AGHT+IGju1kZbge/8X+qlAXgGAV0BOFBek2NHOKS7g2pGIoP5uupBCjnIw8zjFIGr/vqf6m1u4l1WZuLypzFCpJph0c= X-Received: by 2002:a05:6512:3582:b0:4fb:8987:734e with SMTP id m2-20020a056512358200b004fb8987734emr1406215lfr.68.1691666304900; Thu, 10 Aug 2023 04:18:24 -0700 (PDT) MIME-Version: 1.0 References: <20230730224413.6411-1-yuanhao.xie@intel.com> <20230730224413.6411-4-yuanhao.xie@intel.com> In-Reply-To: <20230730224413.6411-4-yuanhao.xie@intel.com> From: "Ard Biesheuvel" Date: Thu, 10 Aug 2023 13:18:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [Patch V7 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi. To: devel@edk2.groups.io, yuanhao.xie@intel.com Cc: Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Ard Biesheuvel , Jiewen Yao , Jordan Justen Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Y+5JIIGa; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, 31 Jul 2023 at 00:44, Yuanhao Xie wrote: > > Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by > INIT-SIPI-SIPI. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Signed-off-by: Yuanhao Xie > Reviewed-by: Ray Ni Reviewed-by: Ard Biesheuvel > --- > OvmfPkg/OvmfPkgIa32.dsc | 9 ++++++++- > OvmfPkg/OvmfPkgIa32X64.dsc | 7 +++++++ > OvmfPkg/OvmfPkgX64.dsc | 7 +++++++ > 3 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index ed36935770..80d8e37009 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -1,7 +1,7 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # Copyright (c) Microsoft Corporation. > # > @@ -585,6 +585,13 @@ > > # Point to the MdeModulePkg/Application/UiApp/UiApp.inf > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } > + # > + # INIT is now triggered before BIOS by ucode/hardware. In the OVMF > + # environment, QEMU lacks a simulation for the INIT process. > + # To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to > + # broadcast INIT-SIPI-SIPI for the first time. > + # > + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE > > ################################################################################ > # > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 919315e4cb..d9757149e3 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -566,6 +566,13 @@ > !if $(SOURCE_DEBUG_ENABLE) == TRUE > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 > !endif > + # > + # INIT is now triggered before BIOS by ucode/hardware. In the OVMF > + # environment, QEMU lacks a simulation for the INIT process. > + # To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to > + # broadcast INIT-SIPI-SIPI for the first time. > + # > + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE > > [PcdsFixedAtBuild.IA32] > # > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 823de0d0f9..b12d874daa 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -615,6 +615,13 @@ > > # Point to the MdeModulePkg/Application/UiApp/UiApp.inf > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } > + # > + # INIT is now triggered before BIOS by ucode/hardware. In the OVMF > + # environment, QEMU lacks a simulation for the INIT process. > + # To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to > + # broadcast INIT-SIPI-SIPI for the first time. > + # > + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE > > ################################################################################ > # > -- > 2.36.1.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107684): https://edk2.groups.io/g/devel/message/107684 Mute This Topic: https://groups.io/mt/100451989/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-