From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, jiewen.yao@intel.com
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Jake Garver <jake@nvidia.com>,
"jbrasen@nvidia.com" <jbrasen@nvidia.com>,
"ashishsingha@nvidia.com" <ashishsingha@nvidia.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf
Date: Thu, 26 Jan 2023 10:08:28 +0100 [thread overview]
Message-ID: <CAMj1kXGMdwQN04QGFnDB1oWdTMb_kJv+hJ6r_oH=rtZOEJK7Ng@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXH_zgs-tute5omDS6E3ZZaAJ-9msnchAhcKg2uLnWAKAw@mail.gmail.com>
On Thu, 26 Jan 2023 at 09:03, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Thu, 26 Jan 2023 at 02:42, Yao, Jiewen <jiewen.yao@intel.com> wrote:
> >
> > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> >
>
> Thanks, I'll go and merge this.
>
>
Merged as #3947, thanks
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Sent: Thursday, January 26, 2023 3:44 AM
> > > To: Jake Garver <jake@nvidia.com>; devel@edk2.groups.io
> > > Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen
> > > <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> > > <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Kinney,
> > > Michael D <michael.d.kinney@intel.com>
> > > Subject: RE: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in
> > > SmmCryptLib.inf
> > >
> > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > > Mike
> > >
> > >
> > > > -----Original Message-----
> > > > From: Jake Garver <jake@nvidia.com>
> > > > Sent: Wednesday, January 25, 2023 11:22 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen
> > > <jiewen.yao@intel.com>; Wang, Jian J
> > > > <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin
> > > <guomin.jiang@intel.com>; Kinney, Michael
> > > > D <michael.d.kinney@intel.com>; Jake Garver <jake@nvidia.com>
> > > > Subject: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in
> > > SmmCryptLib.inf
> > > >
> > > > These sections were removed mistakenly. SmmCryptLib.inf supports these
> > > > architectures.
> > > >
> > > > Signed-off-by: Jake Garver <jake@nvidia.com>
> > > > ---
> > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > index 55df99f843..ab19930871 100644
> > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > @@ -75,6 +75,12 @@
> > > > [Sources.X64]
> > > > Rand/CryptRandTsc.c
> > > >
> > > > +[Sources.ARM]
> > > > + Rand/CryptRand.c
> > > > +
> > > > +[Sources.AARCH64]
> > > > + Rand/CryptRand.c
> > > > +
> > > > [Packages]
> > > > MdePkg/MdePkg.dec
> > > > CryptoPkg/CryptoPkg.dec
> > > > --
> > > > 2.17.1
> >
> >
> >
> >
> >
> >
prev parent reply other threads:[~2023-01-26 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 19:21 [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf Jake Garver
2023-01-25 19:44 ` Michael D Kinney
2023-01-26 1:41 ` Yao, Jiewen
2023-01-26 8:03 ` [edk2-devel] " Ard Biesheuvel
2023-01-26 9:08 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGMdwQN04QGFnDB1oWdTMb_kJv+hJ6r_oH=rtZOEJK7Ng@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox