public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@quicinc.com>
Cc: devel@edk2.groups.io, Pierre Gondois <pierre.gondois@arm.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Sami Mujawar <sami.mujawar@arm.com>,
	 Thomas Abraham <thomas.abraham@arm.com>
Subject: Re: [PATCH edk2-platforms v2 0/2] Platform/ARM/JunoPkg: Timer fixes
Date: Tue, 21 Feb 2023 09:49:18 +0100	[thread overview]
Message-ID: <CAMj1kXGMgt+SMp0Gj+HmF9NGdyxV2DwmKTsVzU7T1ddoy-vP8g@mail.gmail.com> (raw)
In-Reply-To: <20230221010242.1038521-1-rebecca@quicinc.com>

On Tue, 21 Feb 2023 at 02:03, Rebecca Cran <rebecca@quicinc.com> wrote:
>
> The use of the EmbeddedPkg/MetronomeDxe driver on Juno can cause problems
> with drivers that use gBS->Stall, since it takes 10x longer than
> requested. For example requesting a timeout of 1 ms when doing a USB
> bulk transfer results in it taking 100 ms. Switching to the
> MdeModulePkg/Universal/Metronome driver fixes this since it assumes the
> timer clock ticks at least every 100 ns.
>
> While here, set the PCD value of the timer frequency to 0 so it gets
> read from the SoC instead of hard-coding it.
>
> Changes in v2:
>
> Dropped the patch to set PcdTimerPeriod.
>
> Rebecca Cran (2):
>   Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome
>     driver
>   Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from
>     CNTFRQ_EL0
>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Pushed as 81ec441723a0..e20ee6e3a65d

Thanks!

>  Platform/ARM/JunoPkg/ArmJuno.dsc | 6 +++---
>  Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.30.2
>

      parent reply	other threads:[~2023-02-21  8:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21  1:02 [PATCH edk2-platforms v2 0/2] Platform/ARM/JunoPkg: Timer fixes Rebecca Cran
2023-02-21  1:02 ` [PATCH edk2-platforms v2 1/2] Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome driver Rebecca Cran
2023-02-21  8:44   ` Ard Biesheuvel
2023-02-21  1:02 ` [PATCH edk2-platforms v2 2/2] Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from CNTFRQ_EL0 Rebecca Cran
2023-02-21  8:49 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXGMgt+SMp0Gj+HmF9NGdyxV2DwmKTsVzU7T1ddoy-vP8g@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox