From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.38202.1676969373911430373 for ; Tue, 21 Feb 2023 00:49:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XYofMK/D; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7103A60F54 for ; Tue, 21 Feb 2023 08:49:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4F8DC4339C for ; Tue, 21 Feb 2023 08:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676969371; bh=iJd42RFvuw/ZEERCStn4dQz4Z0P/Dcqv36oGXv8jKdM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XYofMK/DTTFi6Z1Hlre8CKZlvz8xUMail2quujgef8e39n40hu0OYVHZNWJezwc0e 7sshe1G+yq3J/cPjwWO1adKeldu62UvFJcAD4VEWHp73xidRrqaqne4GUPO7ylALv7 K8QsG6iLjMITEu6jIvXXFqTJrqJ6q7xDm/AgRlpNRUJAWW127lIEaFCITu6tI7pBhz tvYjZeH60aN+oBkjPw7JKAwjgn52d9oYiUMKO2GrYm8kE/+ehTBgAdPrFXKU9SY5o1 +nV47420u8EvcKoVOir7n8xQ2YbuOlj3Zp/yjwFqFEo9QGWxcEb+5SRves8DE0gQa9 Dcw/aZZAo2hLg== Received: by mail-lj1-f171.google.com with SMTP id h9so3409654ljq.2 for ; Tue, 21 Feb 2023 00:49:31 -0800 (PST) X-Gm-Message-State: AO0yUKXbxX7tG1+zwyUSAnuKQL2ryrfWDbD43Zrvp5qu7Tecc+ztkRUp tmUFIppeEhru4sSnN6pBb4ktOWriEACpQ7Mg+Gc= X-Google-Smtp-Source: AK7set9EE9ZtUIXIRfLyxsTZ5wRLlZstXAvz5GohGP7B3kUFPMg0dxPnZCBTMOfo1lWdekuTu8xXDz60tluC9DTzWt0= X-Received: by 2002:a05:651c:326:b0:28e:d4ae:90ab with SMTP id b6-20020a05651c032600b0028ed4ae90abmr1478632ljp.2.1676969369824; Tue, 21 Feb 2023 00:49:29 -0800 (PST) MIME-Version: 1.0 References: <20230221010242.1038521-1-rebecca@quicinc.com> In-Reply-To: <20230221010242.1038521-1-rebecca@quicinc.com> From: "Ard Biesheuvel" Date: Tue, 21 Feb 2023 09:49:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH edk2-platforms v2 0/2] Platform/ARM/JunoPkg: Timer fixes To: Rebecca Cran Cc: devel@edk2.groups.io, Pierre Gondois , Ard Biesheuvel , Sami Mujawar , Thomas Abraham Content-Type: text/plain; charset="UTF-8" On Tue, 21 Feb 2023 at 02:03, Rebecca Cran wrote: > > The use of the EmbeddedPkg/MetronomeDxe driver on Juno can cause problems > with drivers that use gBS->Stall, since it takes 10x longer than > requested. For example requesting a timeout of 1 ms when doing a USB > bulk transfer results in it taking 100 ms. Switching to the > MdeModulePkg/Universal/Metronome driver fixes this since it assumes the > timer clock ticks at least every 100 ns. > > While here, set the PCD value of the timer frequency to 0 so it gets > read from the SoC instead of hard-coding it. > > Changes in v2: > > Dropped the patch to set PcdTimerPeriod. > > Rebecca Cran (2): > Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome > driver > Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from > CNTFRQ_EL0 > Reviewed-by: Ard Biesheuvel Pushed as 81ec441723a0..e20ee6e3a65d Thanks! > Platform/ARM/JunoPkg/ArmJuno.dsc | 6 +++--- > Platform/ARM/JunoPkg/ArmJuno.fdf | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > -- > 2.30.2 >