From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 56D61D81311 for ; Thu, 7 Sep 2023 09:55:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/OSPmiun4m3tKduXKEw7I19tSH8pH9lyHOhNmag8tBY=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694080511; v=1; b=WZzS7E2ZN5QcWjoSs1VeXex+mQUU2sCPpfmQQOKP84nDLT6dqL1riIu5dwaCo3GMi9+cFh8T 0yn2GNAZmVh7r1uF2BjaHtF0wU5/3KCPk9ijKMloXqVSbPsL98Xxn1uhjsuUZErt7BPp0GCCp4z l2FnE5XvXW3CYWiSO6/VzkAg= X-Received: by 127.0.0.2 with SMTP id zwTFYY7687511xsgcNpxHdPL; Thu, 07 Sep 2023 02:55:11 -0700 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.9236.1694080510936907392 for ; Thu, 07 Sep 2023 02:55:11 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2BDDCB81D8F for ; Thu, 7 Sep 2023 09:55:09 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E9E7C43215 for ; Thu, 7 Sep 2023 09:55:07 +0000 (UTC) X-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-500c7796d8eso1231343e87.1 for ; Thu, 07 Sep 2023 02:55:07 -0700 (PDT) X-Gm-Message-State: CsbDq29vCntPMkvHLANiFttGx7686176AA= X-Google-Smtp-Source: AGHT+IFBrqKby0akglAMiiDw3Qx0narLD2tmPfWYYq9W1CN2eNLn/lZyL03yZU1vQmvb2V2e3y2aKOuhG/iaK7k3lTI= X-Received: by 2002:a05:6512:2e6:b0:500:9f85:6e84 with SMTP id m6-20020a05651202e600b005009f856e84mr3529046lfq.3.1694080505195; Thu, 07 Sep 2023 02:55:05 -0700 (PDT) MIME-Version: 1.0 References: <20230907083429.82300-1-corvink@FreeBSD.org> <20230907083429.82300-2-corvink@FreeBSD.org> In-Reply-To: <20230907083429.82300-2-corvink@FreeBSD.org> From: "Ard Biesheuvel" Date: Thu, 7 Sep 2023 11:54:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory To: devel@edk2.groups.io, corvink@freebsd.org Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Rebecca Cran , Peter Grehan Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WZzS7E2Z; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Thu, 7 Sept 2023 at 10:34, Corvin K=C3=B6hne wrote= : > > If OVMF fails to find the RSDP in memory, it should fall back installing > the statically provided ACPI tables. > > Signed-off-by: Corvin K=C3=B6hne > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Rebecca Cran > Cc: Peter Grehan Nit: please cc the cover letter to the same group of people as the actual patches. Typically, I add the cc's to the cover letter only, and use --cc-cover with git send-email. That way, the cc's don't pollute the commit log either. The patch looks fine to me but i'd like someone with a clue about bhyve to review/ack it as well. Thanks, Ard. > --- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve= /AcpiPlatformDxe/AcpiPlatform.c > index fb926a8bd803..57b1e7a99666 100644 > --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > @@ -259,19 +259,17 @@ InstallAcpiTables ( > BHYVE_BIOS_PHYSICAL_END, > &Rsdp > ); > - if (EFI_ERROR (Status)) { > - return Status; > - } > - > - Status =3D InstallAcpiTablesFromRsdp ( > - AcpiTable, > - Rsdp > - ); > if (!EFI_ERROR (Status)) { > - return EFI_SUCCESS; > + Status =3D InstallAcpiTablesFromRsdp ( > + AcpiTable, > + Rsdp > + ); > + if (!EFI_ERROR (Status)) { > + return EFI_SUCCESS; > + } > } > > - if (Status !=3D EFI_NOT_FOUND) { > + if (EFI_ERROR (Status)) { > DEBUG ( > ( > DEBUG_WARN, > @@ -280,7 +278,6 @@ InstallAcpiTables ( > Status > ) > ); > - return Status; > } > > Status =3D InstallOvmfFvTables (AcpiTable); > -- > 2.42.0 > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108371): https://edk2.groups.io/g/devel/message/108371 Mute This Topic: https://groups.io/mt/101210702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-