From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web09.2687.1615499321724542499
 for <devel@edk2.groups.io>;
 Thu, 11 Mar 2021 13:48:41 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jH0Ghzre;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id C8E0F64F85
	for <devel@edk2.groups.io>; Thu, 11 Mar 2021 21:12:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1615497139;
	bh=cK/AMo8FRwC2y04UxxAdV/syYxwTEpB5vkS6Qbxxz4M=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=jH0GhzreJA053VERR46EgRPke04li2ItT0tYsHebMOvkK9h8rjHxXvogTSJ1RtKoz
	 Jw49SejGduld8WX0LFAgCpbOKvV8XpPXBu37REUMiPKWd4WUJi6RnyPUbEEoUUoxPM
	 NIoCjE84Qzd4Yq0VnRUOBzIQjeJp3lC/rczsxItG8R/je6Y3mTntXKeeoIcypd+w2M
	 6DX/Np83RT1yt9c+uGR04O0eopPlhj//5r5kJqdeLEjmzokt3AWdmkvjpgwCtbM49E
	 5rvdaximj0U5TwH1h75qvkdxS9ZXTK+c8h9h9RHhcLsAqlGLu3JO4mIS0MJrIWy4jG
	 SK4KuMdYDhinA==
Received: by mail-oi1-f179.google.com with SMTP id v192so17081835oia.5
        for <devel@edk2.groups.io>; Thu, 11 Mar 2021 13:12:19 -0800 (PST)
X-Gm-Message-State: AOAM532quiWR/WfHaiAPOjm6p+98mtNkAhN5Ak/7E684/c1knUR56D6D
	vjd17LR6Ti8R75swcwx1kaLNzu+oQMTxCp5zgZw=
X-Google-Smtp-Source: ABdhPJyxFyLVjsRhQEh8L1Oxh61jUKhXO2OC5iVPZOAWtepeatAgZQpZ2qfNct20fFejxLeTcEc1s1lT7xc4EnzOnqQ=
X-Received: by 2002:aca:1a01:: with SMTP id a1mr3531280oia.33.1615497139010;
 Thu, 11 Mar 2021 13:12:19 -0800 (PST)
MIME-Version: 1.0
References: <20210311202020.29125-1-shashi.mallela@linaro.org>
In-Reply-To: <20210311202020.29125-1-shashi.mallela@linaro.org>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Thu, 11 Mar 2021 22:12:07 +0100
X-Gmail-Original-Message-ID: <CAMj1kXGN_EEQHEy5B1PU-A8rGMojXU3vgvjJfcA00A+8d4fAOg@mail.gmail.com>
Message-ID: <CAMj1kXGN_EEQHEy5B1PU-A8rGMojXU3vgvjJfcA00A+8d4fAOg@mail.gmail.com>
Subject: Re: [PATCH v1] ArmPkg/ArmPkg.dec: New pcd defined for GICv3 ITS
To: Shashi Mallela <shashi.mallela@linaro.org>
Cc: Leif Lindholm <leif@nuviainc.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Ray Ni <ray.ni@intel.com>, devel@edk2.groups.io
Content-Type: text/plain; charset="UTF-8"

Hello Shashi,

On Thu, 11 Mar 2021 at 21:20, Shashi Mallela <shashi.mallela@linaro.org> wrote:
>
> To enable detection of GICv3 Interrupt Translation Service capability
> in the ACPI MADT,a new pcd setting has been created in edk2.This pcd
> setting would be referenced by edk2-platform code to advertise the ITS
> physical base address within GIC ITS structure of MADT.
>

This does not explain why the PCD in question should be defined in
ArmPkg. UEFI itself does not use interrupts other than the timer one
in the first place, so ITS, LPI, MSI etc are also irrelevant to it.

I think it would be better to find a home for this PCD in edk2-platforms itself.


> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
> ---
>  ArmPkg/ArmPkg.dec | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index a8a22c649f..c22b7d0c42 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -266,6 +266,7 @@
>    # Base address for the GIC Redistributor region that contains the boot CPU
>    gArmTokenSpaceGuid.PcdGicRedistributorsBase|0|UINT64|0x0000000E
>    gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0|UINT64|0x0000000D
> +  gArmTokenSpaceGuid.PcdGicItsBase|0|UINT64|0x0000000F
>    gArmTokenSpaceGuid.PcdGicSgiIntId|0|UINT32|0x00000025
>
>    #
> --
> 2.27.0
>