[PATCH v1] ArmPkg/ArmPkg.dec: New pcd defined for GICv3 ITS

[PATCH v1] ArmPkg/ArmPkg.dec: New pcd defined for GICv3 ITS

[Shashi Mallela]

To enable detection of GICv3 Interrupt Translation Service capability
in the ACPI MADT,a new pcd setting has been created in edk2.This pcd
setting would be referenced by edk2-platform code to advertise the ITS
physical base address within GIC ITS structure of MADT.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
---
 ArmPkg/ArmPkg.dec | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
index a8a22c649f..c22b7d0c42 100644
--- a/ArmPkg/ArmPkg.dec
+++ b/ArmPkg/ArmPkg.dec
@@ -266,6 +266,7 @@
   # Base address for the GIC Redistributor region that contains the boot CPU
   gArmTokenSpaceGuid.PcdGicRedistributorsBase|0|UINT64|0x0000000E
   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0|UINT64|0x0000000D
+  gArmTokenSpaceGuid.PcdGicItsBase|0|UINT64|0x0000000F
   gArmTokenSpaceGuid.PcdGicSgiIntId|0|UINT32|0x00000025
 
   #
-- 
2.27.0

Re: [PATCH v1] ArmPkg/ArmPkg.dec: New pcd defined for GICv3 ITS

[Ard Biesheuvel]

Hello Shashi,

On Thu, 11 Mar 2021 at 21:20, Shashi Mallela <shashi.mallela@linaro.org> wrote:
>
> To enable detection of GICv3 Interrupt Translation Service capability
> in the ACPI MADT,a new pcd setting has been created in edk2.This pcd
> setting would be referenced by edk2-platform code to advertise the ITS
> physical base address within GIC ITS structure of MADT.
>

This does not explain why the PCD in question should be defined in
ArmPkg. UEFI itself does not use interrupts other than the timer one
in the first place, so ITS, LPI, MSI etc are also irrelevant to it.

I think it would be better to find a home for this PCD in edk2-platforms itself.


> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
> ---
>  ArmPkg/ArmPkg.dec | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index a8a22c649f..c22b7d0c42 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -266,6 +266,7 @@
>    # Base address for the GIC Redistributor region that contains the boot CPU
>    gArmTokenSpaceGuid.PcdGicRedistributorsBase|0|UINT64|0x0000000E
>    gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0|UINT64|0x0000000D
> +  gArmTokenSpaceGuid.PcdGicItsBase|0|UINT64|0x0000000F
>    gArmTokenSpaceGuid.PcdGicSgiIntId|0|UINT32|0x00000025
>
>    #
> --
> 2.27.0
>

Re: [PATCH v1] ArmPkg/ArmPkg.dec: New pcd defined for GICv3 ITS

[Shashi Mallela]

Hi Ard,

Thanks for your comments.
Please ignore this edk2 patch as i have now localised the new pcd
creation and reference within SbsaQemu of edk2-platform.
The edk2-platform patchset has been updated accordingly.

Shashi

On Thu, 2021-03-11 at 22:12 +0100, Ard Biesheuvel wrote:
> Hello Shashi,
> 
> On Thu, 11 Mar 2021 at 21:20, Shashi Mallela <
> shashi.mallela@linaro.org> wrote:
> > To enable detection of GICv3 Interrupt Translation Service
> > capability
> > in the ACPI MADT,a new pcd setting has been created in edk2.This
> > pcd
> > setting would be referenced by edk2-platform code to advertise the
> > ITS
> > physical base address within GIC ITS structure of MADT.
> > 
> 
> This does not explain why the PCD in question should be defined in
> ArmPkg. UEFI itself does not use interrupts other than the timer one
> in the first place, so ITS, LPI, MSI etc are also irrelevant to it.
> 
> I think it would be better to find a home for this PCD in edk2-
> platforms itself.
> 
> 
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
> > ---
> >  ArmPkg/ArmPkg.dec | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> > index a8a22c649f..c22b7d0c42 100644
> > --- a/ArmPkg/ArmPkg.dec
> > +++ b/ArmPkg/ArmPkg.dec
> > @@ -266,6 +266,7 @@
> >    # Base address for the GIC Redistributor region that contains
> > the boot CPU
> >    gArmTokenSpaceGuid.PcdGicRedistributorsBase|0|UINT64|0x0000000E
> >    gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0|UINT64|0x00000
> > 00D
> > +  gArmTokenSpaceGuid.PcdGicItsBase|0|UINT64|0x0000000F
> >    gArmTokenSpaceGuid.PcdGicSgiIntId|0|UINT32|0x00000025
> > 
> >    #
> > --
> > 2.27.0
> >