From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web09.7677.1643473135359271058
 for <devel@edk2.groups.io>;
 Sat, 29 Jan 2022 08:18:55 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IxCbwXRJ;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id A7AFE60B8E
	for <devel@edk2.groups.io>; Sat, 29 Jan 2022 16:18:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C852C340ED
	for <devel@edk2.groups.io>; Sat, 29 Jan 2022 16:18:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1643473134;
	bh=qw95LFT2Zq6iMQcIklCWSxxjOEs2yOIRBvgkeFFxKh0=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=IxCbwXRJ5LDCIjRivx+dnuLLX8UhRVkJyKy5jKTydEEBCxTmWQiOaAQLDPyuc5GAX
	 nbRpFn4V6ijD0DAsP9asFFgWL2qziZ4IEcn3GGLZpPfxpgVjkBXUpUxfoHqK/LzTFR
	 Th9leZxdbU5pm/eqOixCbGPa/qyTAbCQxu4wIv/r5dZxSgDk5l4KQLVw63BuXuSvqq
	 ZDE6gqwYd6qQT9y38l6Jvsiq0J5tKHtQDOGb+H6FjNT9EEAExSWuGKU3Q50wua6BUv
	 U0YC/UlsPVL5kEbPsdD9sTEqn71P1J3HE02+757Y1+2LJ7hHX5NLbsJDyVhbskxw2h
	 YeoCJPn/if54Q==
Received: by mail-wm1-f53.google.com with SMTP id f22-20020a1c1f16000000b003525bf08b1eso1809539wmf.0
        for <devel@edk2.groups.io>; Sat, 29 Jan 2022 08:18:54 -0800 (PST)
X-Gm-Message-State: AOAM532E4XTisQvSMltW0aCB8bDc5uwLRD2UhWGv6hnijtg7GtuKklDn
	ZEpt/ZDYuQ9DNX4F6kf6hcvhTXc7gQQyH+up3cY=
X-Google-Smtp-Source: ABdhPJw57gyTvbssssxTDaUoHRk8opKlXaxiinn/c3hbMeVwt2deopI8MlVzwqlGylDZYyHJOo0+Hsv4bEmzlkPL46A=
X-Received: by 2002:a1c:a90d:: with SMTP id s13mr11633863wme.32.1643473132402;
 Sat, 29 Jan 2022 08:18:52 -0800 (PST)
MIME-Version: 1.0
References: <20220114005044.1975-1-guomin.jiang@intel.com> <20220114005044.1975-3-guomin.jiang@intel.com>
In-Reply-To: <20220114005044.1975-3-guomin.jiang@intel.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Sat, 29 Jan 2022 17:18:40 +0100
X-Gmail-Original-Message-ID: <CAMj1kXGNbDROKhL4LDtGHKKDB+1GOWGQ3YSNHaxRJXD2SbtsAw@mail.gmail.com>
Message-ID: <CAMj1kXGNbDROKhL4LDtGHKKDB+1GOWGQ3YSNHaxRJXD2SbtsAw@mail.gmail.com>
Subject: Re: [PATCH 02/11] ArmVirtPkg: Remove All UGA Support
To: Guomin Jiang <guomin.jiang@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, GuoMinJ <newexplorerj@gmail.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Leif Lindholm <leif@nuviainc.com>, 
	Sami Mujawar <sami.mujawar@arm.com>, Gerd Hoffmann <kraxel@redhat.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 14 Jan 2022 at 01:51, Guomin Jiang <guomin.jiang@intel.com> wrote:
>
> From: GuoMinJ <newexplorerj@gmail.com>
>
> REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
>
> Remove PcdConOutGopSupport, it is unnecessary any more.
> Remove All UGA Support in ArmVirtPkg
>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>

As I was not cc'ed on the cover letter,

Acked-by: Ard Biesheuvel <ardb@kernel.org>

for the three patches I was cc'ed on.


> ---
>  ArmVirtPkg/ArmVirtQemu.dsc       | 5 -----
>  ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 -----
>  2 files changed, 10 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 84c28b0c1df4..d18ad9c26672 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -124,11 +124,6 @@ [PcdsFeatureFlag.common]
>    gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
>    gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
>
> -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> -  #  It could be set FALSE to save size.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> -
>    gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
>
>    gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE)
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 8e82c5050f6b..c8af8cefc2c5 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -107,11 +107,6 @@ [PcdsFeatureFlag.common]
>    gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
>    gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
>
> -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> -  #  It could be set FALSE to save size.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> -
>    gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
>
>  [PcdsFixedAtBuild.common]
> --
> 2.30.0.windows.2
>