public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	joey.gouly@arm.com,
	 "ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	"leif@nuviainc.com" <leif@nuviainc.com>,
	 Sami Mujawar <Sami.Mujawar@arm.com>,
	Andreas Sandberg <Andreas.Sandberg@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3
Date: Sun, 23 May 2021 11:03:14 +0200	[thread overview]
Message-ID: <CAMj1kXGNtSwq9czVwptWGtaHcOUsofxi0JRA5NsPiZoiT5mjsQ@mail.gmail.com> (raw)
In-Reply-To: <15e1864b-1eb3-921b-3b10-2aba99afc9a0@redhat.com>

On Sun, 23 May 2021 at 10:55, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 05/21/21 12:49, Joey Gouly wrote:
> >> From: Joey Gouly <joey.gouly@arm.com>
> >> Sent: 09 March 2021 16:45
> >> Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3
> >
> > Hi,
> >
> > A little ping on this. Can someone take a look?
> >
> > There was a similar patch here, that addressed the same issue https://edk2.groups.io/g/devel/topic/82327316#74401 so I think it would be good get this in.
>
> This even looks like a candidate for edk2-stable202105 to me (it's small
> and arguably a clear-cut bugfix).
>
> NB the comment style should be:
>
>   //
>   // Interrupt ID 1020-1023 are reserved:
>   //
>
> IOW, we need a trailing and a leading empty comment line, plus the
> semicolon at the end of the comment should likely be a colon, or maybe
> just a period.
>

With that,

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

  reply	other threads:[~2021-05-23  9:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 16:45 [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3 Joey Gouly
2021-05-21 10:49 ` Joey Gouly
2021-05-23  8:55   ` [edk2-devel] " Laszlo Ersek
2021-05-23  9:03     ` Ard Biesheuvel [this message]
2021-05-23 11:26       ` Laszlo Ersek
2021-05-24 12:58         ` Sami Mujawar
2021-05-25 11:55           ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXGNtSwq9czVwptWGtaHcOUsofxi0JRA5NsPiZoiT5mjsQ@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox